Skip to content

Misc. unused opens analyzer fixes #18510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Update release notes

23d3cbc
Select commit
Loading
Failed to load commit list.
Draft

Misc. unused opens analyzer fixes #18510

Update release notes
23d3cbc
Select commit
Loading
Failed to load commit list.
Azure Pipelines / fsharp-ci failed Apr 27, 2025 in 1h 29m 14s

Build #20250427.2 had test failures

2 errors / 7 warnings

Details

Tests

  • Failed: 6 (0.01%)
  • Passed: 73,864 (97.71%)
  • Other: 1,726 (2.28%)
  • Total: 75,596

Annotations

Check failure on line 278213 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L278213 

(NETCORE_ENGINEERING_TELEMETRY=Test) Failure running tests

Check failure on line 278214 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L278214 

Cmd.exe exited with code '1'.

Check failure on line 1 in Tests.ServiceAnalysis.UnusedOpens.single relative open declaration opens two independent modules in different parent modules

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Tests.ServiceAnalysis.UnusedOpens.single relative open declaration opens two independent modules in different parent modules 

Assert.Equal() Failure: Collections differ
Expected: []
Actual:   [Tuple (10, Tuple (5, 10))]
Raw output 
   at Tests.ServiceAnalysis.UnusedOpens.op_EqualsGreater(String source, FSharpList`1 expectedRanges) in D:\a\_work\1\s\vsintegration\tests\UnitTests\UnusedOpensTests.fs:line 41
   at Tests.ServiceAnalysis.UnusedOpens.single relative open declaration opens two independent modules in different parent modules() in D:\a\_work\1\s\vsintegration\tests\UnitTests\UnusedOpensTests.fs:line 705

Check failure on line 1 in Tests.ServiceAnalysis.UnusedOpens.open statement duplication in parent module is unused

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Tests.ServiceAnalysis.UnusedOpens.open statement duplication in parent module is unused 

Assert.Equal() Failure: Collections differ
Expected: [Tuple (5, Tuple (9, 18))]
Actual:   [Tuple (3, Tuple (5, 14))]
Raw output 
   at Tests.ServiceAnalysis.UnusedOpens.op_EqualsGreater(String source, FSharpList`1 expectedRanges) in D:\a\_work\1\s\vsintegration\tests\UnitTests\UnusedOpensTests.fs:line 41
   at Tests.ServiceAnalysis.UnusedOpens.open statement duplication in parent module is unused() in D:\a\_work\1\s\vsintegration\tests\UnitTests\UnusedOpensTests.fs:line 99

Check failure on line 1 in Tests.ServiceAnalysis.UnusedOpens.auto open module opened before enclosing one is handled correctly

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Tests.ServiceAnalysis.UnusedOpens.auto open module opened before enclosing one is handled correctly 

Assert.Equal() Failure: Collections differ
Expected: []
Actual:   [Tuple (7, Tuple (5, 8))]
Raw output 
   at Tests.ServiceAnalysis.UnusedOpens.op_EqualsGreater(String source, FSharpList`1 expectedRanges) in D:\a\_work\1\s\vsintegration\tests\UnitTests\UnusedOpensTests.fs:line 41
   at Tests.ServiceAnalysis.UnusedOpens.auto open module opened before enclosing one is handled correctly() in D:\a\_work\1\s\vsintegration\tests\UnitTests\UnusedOpensTests.fs:line 690

Check failure on line 1 in Tests.ServiceAnalysis.UnusedOpens.opening parent module after one of its auto open module was opened should be marked as unused

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Tests.ServiceAnalysis.UnusedOpens.opening parent module after one of its auto open module was opened should be marked as unused 

Assert.Equal() Failure: Collections differ
Expected: [Tuple (13, Tuple (5, 52))]
Actual:   [Tuple (12, Tuple (5, 68))]
Raw output 
   at Tests.ServiceAnalysis.UnusedOpens.op_EqualsGreater(String source, FSharpList`1 expectedRanges) in D:\a\_work\1\s\vsintegration\tests\UnitTests\UnusedOpensTests.fs:line 41
   at Tests.ServiceAnalysis.UnusedOpens.opening parent module after one of its auto open module was opened should be marked as unused() in D:\a\_work\1\s\vsintegration\tests\UnitTests\UnusedOpensTests.fs:line 190
View more details on Azure Pipelines