-
Notifications
You must be signed in to change notification settings - Fork 815
Update System packages #18514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update System packages #18514
Conversation
✅ No release notes required |
Is there a better way than adjusting |
To recap, it's there to detect when we are depending on something that isn't built as part of the source build process, I too am a little bothered that we have to put items in there for system assemblies, given they are for certain built by sourcebuild. I will work with the sourcebuild team to see if there is something we can do that will allow us to specify the currently built versions first, rather than picking a package we know already exists. I'm not optimistic, sourcebuild and the sdk build is a monumentally complicated piece of software. And the SourceBuildPrebuiltBaseline.xml does protect us against inadvertently referencing something that sourcebuild hasn't build. |
Please use the @dotnet/source-build team for pings like this. I am not always very responsive and there are several other source build experts on the team. |
The source build Package Dependency Flow document describes in detail how package versions are resolved in source-build. For these system packages, they will either come from the source-build-reference-packages repo or they will get lifted to the latest version. They get lifted when the dependency is declared in the Version.Details.xml file. If you want to ease maintenance, declaring these packages in the Version.Details.xml file would accomplish that but it would also mean source-build and the MSFT build would build with different versions of the dependencies. If that is not appealing, then these system packages need to be added to source-build-reference-packages repo if they do not already exist. |
We're at 8.0.0 but there is new functionality in System.Diagnostics.DiagnosticSource 9.0.0.