Skip to content

Update System packages #18514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update System packages #18514

wants to merge 1 commit into from

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Apr 28, 2025

We're at 8.0.0 but there is new functionality in System.Diagnostics.DiagnosticSource 9.0.0.

Copy link
Contributor

✅ No release notes required

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Apr 28, 2025
@T-Gro
Copy link
Member

T-Gro commented Apr 28, 2025

@MichaelSimons :

Is there a better way than adjusting
https://github.com/dotnet/fsharp/blob/main/eng/SourceBuildPrebuiltBaseline.xml prebuilds every time we want to upgrade a System package?

@KevinRansom
Copy link
Member

KevinRansom commented May 1, 2025

Is there a better way than adjusting https://github.com/dotnet/fsharp/blob/main/eng/SourceBuildPrebuiltBaseline.xml prebuilds every time we want to upgrade a System package?

To recap, it's there to detect when we are depending on something that isn't built as part of the source build process, I too am a little bothered that we have to put items in there for system assemblies, given they are for certain built by sourcebuild. I will work with the sourcebuild team to see if there is something we can do that will allow us to specify the currently built versions first, rather than picking a package we know already exists. I'm not optimistic, sourcebuild and the sdk build is a monumentally complicated piece of software. And the SourceBuildPrebuiltBaseline.xml does protect us against inadvertently referencing something that sourcebuild hasn't build.

@MichaelSimons
Copy link
Member

@MichaelSimons :

Is there a better way than adjusting https://github.com/dotnet/fsharp/blob/main/eng/SourceBuildPrebuiltBaseline.xml prebuilds every time we want to upgrade a System package?

Please use the @dotnet/source-build team for pings like this. I am not always very responsive and there are several other source build experts on the team.

@MichaelSimons
Copy link
Member

The source build Package Dependency Flow document describes in detail how package versions are resolved in source-build. For these system packages, they will either come from the source-build-reference-packages repo or they will get lifted to the latest version. They get lifted when the dependency is declared in the Version.Details.xml file.

If you want to ease maintenance, declaring these packages in the Version.Details.xml file would accomplish that but it would also mean source-build and the MSFT build would build with different versions of the dependencies. If that is not appealing, then these system packages need to be added to source-build-reference-packages repo if they do not already exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants