Skip to content

Code completion: prefer the first naming environment for range #18516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

auduchinok
Copy link
Member

@auduchinok auduchinok commented Apr 28, 2025

Fixes #18518.

This PR introduces a hack that doesn't let it pick this environment, but it doesn't look correct to me (at least for now). I'm still opening this PR to see if any tests fail.

The main question further is where this environment is created and why doesn't it include the type?

Copy link
Contributor

❗ Release notes required

@auduchinok,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md No release notes found or release notes format is not correct

@auduchinok auduchinok changed the title Fix code completion for types previously defined in own namespace Code completion: prefer the first naming environment for range Apr 28, 2025
@auduchinok auduchinok closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Code completion considers types from own namespace non-imported
1 participant