Skip to content

Multi agent parallel testing in CI #18523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Apr 29, 2025

Make #18517 work.

Copy link
Contributor

✅ No release notes required

@majocha
Copy link
Contributor Author

majocha commented Apr 29, 2025

This kind of worked, but now Linux is the bottleneck, oh well :)

@T-Gro
Copy link
Member

T-Gro commented Apr 29, 2025

Linux and MacOs will likely alternate in being the slowest, MacOs also has the smallest pool of available machines.

I do like the numbers very much.
I will be happy to get this in on a per-partes basis ;; always focusing on the currently slowest leg(s).

let addBatchTrait (testCase: ITestCase) =
let data = Text.Encoding.UTF8.GetBytes testCase.DisplayName
let hashCode = BitConverter.ToUInt32(sha.ComputeHash(data), 0)
let batch = hashCode % 4u + 1u
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why % 4 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to get a number from 1 to 4. this is hardcoded just for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to get the batch number from a custom hashCode that is stable between executions. I heard bad things about String.GetHashcode() in this regard.

@majocha
Copy link
Contributor Author

majocha commented Apr 29, 2025

Now it's important to verify the that number of tests add up correctly 😅
image

@T-Gro
Copy link
Member

T-Gro commented Apr 29, 2025

.. number of unique executed tests.

I would recommend to download testlog.xml files and have a script count unique test entries and compare two sets (prior exection, new execution from 4 jobs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

2 participants