-
Notifications
You must be signed in to change notification settings - Fork 815
Multi agent parallel testing in CI #18523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ No release notes required |
This kind of worked, but now Linux is the bottleneck, oh well :) |
Linux and MacOs will likely alternate in being the slowest, MacOs also has the smallest pool of available machines. I do like the numbers very much. |
let addBatchTrait (testCase: ITestCase) = | ||
let data = Text.Encoding.UTF8.GetBytes testCase.DisplayName | ||
let hashCode = BitConverter.ToUInt32(sha.ComputeHash(data), 0) | ||
let batch = hashCode % 4u + 1u |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why % 4
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to get a number from 1 to 4. this is hardcoded just for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to get the batch number from a custom hashCode that is stable between executions. I heard bad things about String.GetHashcode() in this regard.
.. number of unique executed tests. I would recommend to download testlog.xml files and have a script count unique test entries and compare two sets (prior exection, new execution from 4 jobs) |
Make #18517 work.