Skip to content

Log the start of Static Graph construction #12048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abulyaev
Copy link

Fixes #11166

Context

Changes Made

Log message added

Testing

One test was updated to reflect the change

Notes

@abulyaev
Copy link
Author

@abulyaev please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@@ -1925,6 +1925,9 @@ Utilization: {0} Average Utilization: {1:###.0}</value>
<data name="NuGetAssemblyNotFound" xml:space="preserve">
<value>A required NuGet assembly '{0}' could not be loaded.</value>
</data>
<data name="StaticGraphConstructionStarted" xml:space="preserve">
<value>Static graph construction started.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build locally and commit files generated by that for localization

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@abulyaev abulyaev force-pushed the add-logging-in-start-graph branch from 76a4706 to 06545a5 Compare June 20, 2025 16:44
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question is what log importance level this should be. In @jeffkl's example where constructing the graph takes 30s, it'd be really nice to see it! But in a lot of smaller repos I'd rather avoid a log line like this.

@baronfel do you have opinions?

I kinda want a deferred message, where we log nothing unless it takes 5s (or something) and then log at high pri. But we don't have anything else that works like that and it sounds kinda annoying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph build should log that projects are being evaluated
3 participants