Skip to content

Fix #610 - Update DebuggerDisplay for renamed fields #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2016

Conversation

tbolon
Copy link
Contributor

@tbolon tbolon commented May 13, 2016

Fix #610.

I used Resharper to find invalid names.
Please note that there are still 3 unresolved symbols:

XMakeBuildEngine\Construction\ProjectOnErrorElement.cs:23 Cannot resolve symbol 'ExecuteTargets'
XMakeBuildEngine\Construction\ProjectOutputElement.cs:22 Cannot resolve symbol 'Name'
XMakeBuildEngine\Construction\ProjectOutputElement.cs:22 Cannot resolve symbol 'ItemName'

I do not know how to fix them (there is no corresponding property)

@tbolon tbolon changed the title Fix #610 - Update DebuggerDisplay for reanemd fields Fix #610 - Update DebuggerDisplay for renamed fields May 13, 2016
@AndyGerlicher
Copy link
Contributor

This is great, thank you! I was actually just annoyed by this yesterday and planned to fix this, so great timing!

@rainersigwald
Copy link
Member

rainersigwald commented May 13, 2016

Thank you for the contribution!

there are still 3 unresolved symbols

Well, those errors date back to at least 2010--the earliest copy of the source I had on hand!

Can you make these changes in a separate commit to deal with them?

  • XMakeBuildEngine\Construction\ProjectOnErrorElement.cs: point to ExecuteTargetsAttribute
  • XMakeBuildEngine\Construction\ProjectOutputElement.cs: remove Name
  • XMakeBuildEngine\Construction\ProjectOutputElement.cs: replace ItemName with ItemType

The latter is based on this comment: https://github.com/Microsoft/msbuild/blob/master/src/XMakeBuildEngine/Construction/ProjectOutputElement.cs#L85

The existing changes look good to me.

@tbolon
Copy link
Contributor Author

tbolon commented May 13, 2016

done! 😄

@rainersigwald
Copy link
Member

@dotnet-bot test this please

@rainersigwald
Copy link
Member

Thanks again.

@rainersigwald rainersigwald merged commit ea6af14 into dotnet:master May 13, 2016
@tbolon tbolon deleted the tbolon-610 branch May 17, 2016 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to update [DebuggerDisplay] attributes to match renamed field names
4 participants