Question Switch and Readme #9752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
reviewed
Feb 16, 2024
There was a problem hiding this comment.
I love to see this docuemnted - thank you!!
I'm not a native speaker so please take the suggestions with a grain of salt.
I'd personally strongly preffer the code changes and documentation changes goe in 2 separate PRs - it'd as well help expediate the process (as for the documentation changes we should probably have @rainersigwald or @baronfel have a look, the coding changes can be handled by anyone)
JanKrivanek
approved these changes
Feb 27, 2024
|
FYI. Squashed and re-merge. |
MichalPavlik
approved these changes
Aug 29, 2024
Co-authored-by: MichalPavlik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Question.md