Fix flags in EarlyProp after nullcheck is removed (#112717)

EgorBo · web-flow · commit 2d73b375a8cb · 2025-02-20T14:45:42.000+01:00
diff --git a/src/coreclr/jit/earlyprop.cpp b/src/coreclr/jit/earlyprop.cpp
@@ -457,6 +457,9 @@ bool Compiler::optFoldNullCheck(GenTree* tree, LocalNumberToNullCheckTreeMap* nu
         nullCheckTree->SetHasOrderingSideEffect();
         nullCheckTree->gtFlags |= GTF_IND_NONFAULTING;
 
+        // The current indir is no longer non-faulting.
+        tree->gtFlags &= ~GTF_IND_NONFAULTING;
+
         if (nullCheckParent != nullptr)
         {
             nullCheckParent->gtFlags &= ~GTF_DONT_CSE;

Original file line number	Diff line number	Diff line change
`@@ -457,6 +457,9 @@ bool Compiler::optFoldNullCheck(GenTree* tree, LocalNumberToNullCheckTreeMap* nu`
`457`	`457`	`nullCheckTree->SetHasOrderingSideEffect();`
`458`	`458`	`nullCheckTree->gtFlags \|= GTF_IND_NONFAULTING;`
`459`	`459`
	`460`	`+ // The current indir is no longer non-faulting.`
	`461`	`+ tree->gtFlags &= ~GTF_IND_NONFAULTING;`
	`462`	`+`
`460`	`463`	`if (nullCheckParent != nullptr)`
`461`	`464`	`{`
`462`	`465`	`nullCheckParent->gtFlags &= ~GTF_DONT_CSE;`