Fix flags in EarlyProp after nullcheck is removed #112717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
/azp run runtime-coreclr jitstress-random |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
PTAL @jakobbotsch cc @dotnet/jit-contrib A few diffs, surprisingly, improvements. I guess it's CSE failing for mismatching exception sets? |
EgorBo
commented
Feb 20, 2025
src/coreclr/jit/earlyprop.cpp
Outdated
| @@ -457,6 +457,10 @@ bool Compiler::optFoldNullCheck(GenTree* tree, LocalNumberToNullCheckTreeMap* nu | |||
| nullCheckTree->SetHasOrderingSideEffect(); | |||
| nullCheckTree->gtFlags |= GTF_IND_NONFAULTING; | |||
|
|
|||
| // The current indir is no longer non-faulting. | |||
| tree->gtFlags &= ~GTF_IND_NONFAULTING; | |||
| tree->SetIndirExceptionFlags(this); | |||
There was a problem hiding this comment.
I presume in theory we can avoid removing GTF_IND_NONFAULTING and adding GTF_EXCEPT if the leading (if it is in fact leading) nullcheck had them, but wanted to be on a safer side
There was a problem hiding this comment.
Is the SetIndirExceptionFlags necessary? I assume it should be recomputed below when all side effect flags are updated.
There was a problem hiding this comment.
Correct, GTF_EXCEPT is set later via gtUpdateNodeOperSideEffects, so this one is redundant
jakobbotsch
approved these changes
Feb 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112333
When we have:
if we decide to remove the nullcheck (when it is followed by an indirect which is recognized as an implicit nullcheck for the same address), we should update the flags in that indirect as it's no longer non-faulting.