Skip to content

Add missing compile item in System.Net.WebSockets.Client.Wasm.Tests.csproj #106473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Aug 15, 2024

Fixes:

C:\git\runtime3> .\dotnet.cmd build src\libraries\System.Net.WebSockets.Client\tests\wasm\System.Net.WebSockets.Client.Wasm.Tests.csproj /bl

  Determining projects to restore...
  All projects are up-to-date for restore.
  TestUtilities -> C:\git\runtime3\artifacts\bin\TestUtilities\Debug\net8.0\TestUtilities.dll
C:\git\runtime3\src\libraries\Common\tests\System\Net\Http\GenericLoopbackServer.cs(15,23): error CS0234: The type or namespace name 'Functional' does not exist in the
 namespace 'System.Net.Http' (are you missing an assembly reference?) [C:\git\runtime3\src\libraries\System.Net.WebSockets.Client\tests\wasm\System.Net.WebSockets.Clie
nt.Wasm.Tests.csproj]
C:\git\runtime3\src\libraries\Common\tests\System\Net\Http\GenericLoopbackServer.cs(26,68): error CS0103: The name 'TestHelper' does not exist in the current context [
C:\git\runtime3\src\libraries\System.Net.WebSockets.Client\tests\wasm\System.Net.WebSockets.Client.Wasm.Tests.csproj]

This wasn't caught before because there is no CI validation for building tests for all configurations: #106474

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ViktorHofer ViktorHofer merged commit 66f1d44 into main Aug 15, 2024
3 checks passed
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-4 branch August 15, 2024 17:15
@ViktorHofer
Copy link
Member Author

Merging as this change isn't exercised in CI anyway atm. Will be fixed with #106474

@karelz karelz added this to the 10.0.0 milestone Sep 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants