Skip to content

Delete unnecessary #pragma warning disable #110948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Dec 26, 2024

No description provided.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-linq
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member Author

jkotas commented Dec 26, 2024

@roji These #pragmas were added in #110872. I do not see why they are necessary.

@eiriktsarpalis
Copy link
Member

In some cases Rider will emit warnings that are not issued by the compiler. Perhaps it's an instance of that?

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think these slipped into the commit by mistake, sorry - I no longer remember the specific reason they were needed (in any case, everything builds fine without them and LeftJoin doesn't require them either, so...)

@jkotas jkotas merged commit ebcc886 into dotnet:main Dec 27, 2024
78 of 83 checks passed
@jkotas jkotas deleted the pragma-warning-disable branch December 27, 2024 15:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants