Support disassembling single file bundle for ILSpy #112541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-R2RDump-coreclr
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
Outdated
Show resolved
Hide resolved
This was referenced Feb 13, 2025
jkotas
reviewed
Feb 14, 2025
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Feb 18, 2025
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
Show resolved
Hide resolved
|
@jkotas, is this change ready to be merged? |
gregoral
reviewed
Feb 25, 2025
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
Outdated
Show resolved
Hide resolved
|
@dotnet/area-type-system-and-startup PTLA |
kg
reviewed
Feb 25, 2025
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ReadyToRunReader.cs
Show resolved
Hide resolved
kg
approved these changes
Mar 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILSpy support decompiling single file bundle by keeping the PE images in a single file bundle in memory.
To support disassembling the ready to run code embedded in it, this change accept the PE image content as an immutable byte array. That allow us to disassemble the content without having to save the file on disk.