Skip to content

Don't emit unchecked write barrier for stack-allocated arrays #112711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

Don't emit unchecked write barrier for stack-allocated arrays #112711

merged 2 commits into from
Feb 20, 2025

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Feb 19, 2025

Fixes #112709

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 19, 2025
@EgorBo EgorBo marked this pull request as ready for review February 19, 2025 23:40
@Copilot Copilot AI review requested due to automatic review settings February 19, 2025 23:40
Copilot
Copilot AI reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@EgorBo
Copy link
Member Author

EgorBo commented Feb 19, 2025

PTAL @AndyAyersMS @dotnet/jit-contrib

10 text diffs (basically, unchecked write barrier is replaced with the checked one, no size diff).

image

@EgorBo EgorBo requested a review from AndyAyersMS February 19, 2025 23:41
@amanasifkhalid amanasifkhalid mentioned this pull request Feb 20, 2025
Closed
@AndyAyersMS
Copy link
Member

Is CI is no longer running the full set of tests?

@AndyAyersMS
Copy link
Member

Going to bounce this...

@AndyAyersMS AndyAyersMS reopened this Feb 20, 2025
@EgorBo
Copy link
Member Author

EgorBo commented Feb 20, 2025

Is CI is no longer running the full set of tests?

I think it still is? I bet the new github UI confused you (it did it to me too)

@EgorBo EgorBo merged commit 451a41d into dotnet:main Feb 20, 2025
120 checks passed
@EgorBo EgorBo deleted the fix-array-wb branch February 20, 2025 09:18
@kunalspathak kunalspathak mentioned this pull request Feb 20, 2025
Closed
@AndyAyersMS AndyAyersMS mentioned this pull request Feb 20, 2025
Open
28 tasks
AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this pull request Mar 5, 2025
@AndyAyersMS
[10.0/preview-2] JIT: disable array stack allocation
f1ac70d 
Preview 2 is missing an important fix for stack-allocated arrays of GC types: dotnet#112711.
This can lead to unexpected crashes in jitted code.

Disable array stack allocation to work around this.
@AndyAyersMS AndyAyersMS mentioned this pull request Mar 5, 2025
Merged
ViktorHofer pushed a commit that referenced this pull request Mar 6, 2025
@AndyAyersMS
[10.0/preview-2] JIT: disable array stack allocation (#113181)
07b0519 
* [10.0/preview-2] JIT: disable array stack allocation

Preview 2 is missing an important fix for stack-allocated arrays of GC types: #112711.
This can lead to unexpected crashes in jitted code.

Disable array stack allocation to work around this.

* adjust test case
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JIT: Unchecked write barriers are emitted for stack allocated arrays
2 participants
@EgorBo @AndyAyersMS