Update HelloAndroid App output path and PerfBDN dotnet-install.sh url. #112720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e perfBDN app dotnet-install.sh version retrieval.
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
eng/pipelines/performance/templates/build-perf-bdn-app.yml:89
- Please verify that the updated file path './performance/eng/Version.Details.xml' correctly reflects the new location of the version details XML and that the stricter regex pattern consistently captures the version string in all expected cases.
version=$(sed -nr 's/[[:space:]]*<Dependency Name="Microsoft.NET.Sdk" Version="([^\"]*)"[[:space:]]?.*/\1/p' ./performance/eng/Version.Details.xml)
eng/pipelines/performance/templates/build-perf-sample-apps.yml:29
- Ensure that the updated artifact path points to the correct location for the HelloAndroid app output and is consistent with downstream expectations, especially given the shift from the previous 'publish/apk/bin' directory to 'Bundle/bin'.
rootFolder: $(Build.SourcesDirectory)/artifacts/bin/AndroidSampleApp/arm64/Release/android-arm64/Bundle/bin/HelloAndroid.apk
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
caaavik-msft
approved these changes
Feb 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the folder used for the runtime HelloAndroid app and update the perfBDN app dotnet-install.sh version retrieval and URL.
Partial test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2640497&view=results. This test run included some fixes to later perfBDN issues but demonstrates the work AndroidMono build and working install Maui workload that this PR addresses.