Skip to content

[workloads] Bump net10 downlevel versions to n-1 #112805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2025
+4 −4
Merged

[workloads] Bump net10 downlevel versions to n-1 #112805

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
544d933
Bump net10 downlevel versions to n-1
lewing Feb 21, 2025
36a4d4b
Bump targetframework on wasi librarymode test
lewing Feb 21, 2025
7f975d5
Update PackageVersionNet8 to use PackageVersionNet9
lewing Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
<MinorVersion>0</MinorVersion>
<PatchVersion>0</PatchVersion>
<SdkBandVersion>$(MajorVersion).0.100</SdkBandVersion>
<PackageVersionNet9>9.0.0</PackageVersionNet9>
<PackageVersionNet8>8.0.8</PackageVersionNet8>
<PackageVersionNet9>9.0.2</PackageVersionNet9>
<PackageVersionNet8>8.0.$([MSBuild]::Add($([System.Version]::Parse('$(PackageVersionNet8)').Build),11))</PackageVersionNet8>

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / dotnet-linker-tests (Build osx-x64 release Runtime_Release)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-arm64 release CrossAOT_Mono crossaot)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build ios-arm64 Release AllSubsets_NativeAOT)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build maccatalyst-x64 Release AllSubsets_Mono)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Release AllSubsets_Mono)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build tvos-arm64 Release AllSubsets_Mono)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Release AllSubsets_Mono_Minijit_RuntimeTests minijit)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build ios-arm64 release MonoAOTOffsets)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-arm64 Debug AllSubsets_CoreCLR)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build tvos-arm64 Release AllSubsets_NativeAOT)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-arm64 debug Mono_Runtime)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build ios-arm64 Release AllSubsets_Mono)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build maccatalyst-x64 release MonoAOTOffsets)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug AllSubsets_Mono_LLVMAOT)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Release AllSubsets_Mono_Interpreter_RuntimeTests monointerpreter)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-arm64 Release NativeAOT_Libraries)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build tvossimulator-x64 Debug AllSubsets_Mono)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Release NativeAOT)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 release CrossAOT_Mono crossaot)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 debug Mono_Runtime)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime-dev-innerloop (Build linux-x64 debug Libraries_WithPackages)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / runtime-dev-innerloop (Build linux_musl-x64 debug Musl_Validation)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / dotnet-linker-tests (Build linux-x64 release Runtime_Release)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')

Check failure on line 11 in eng/Versions.props

View check run for this annotation

Azure Pipelines / dotnet-linker-tests (Build browser-wasm linux release Runtime_Release)

eng/Versions.props#L11 

eng/Versions.props(11,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression "[System.Version]::Parse('')" cannot be evaluated. Version string portion was too short or too long. (Parameter 'input')
<PackageVersionNet7>7.0.20</PackageVersionNet7>
<PackageVersionNet6>6.0.$([MSBuild]::Add($([System.Version]::Parse('$(PackageVersionNet8)').Build),25))</PackageVersionNet6>
<PackageVersionNet6>6.0.36</PackageVersionNet6>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<PreReleaseVersionIteration>3</PreReleaseVersionIteration>
<!-- Enable to remove prerelease label. -->
Expand Down
2 changes: 1 addition & 1 deletion src/mono/wasi/Wasi.Build.Tests/WasiLibraryModeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public void LibraryModeBuild(string sdk, bool hasWasmAppBundle)
$"""
<Project Sdk="{sdk}">
<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<TargetFramework>net10.0</TargetFramework>
<TargetFramework>net{Environment.Version}.0</TargetFramework>

similar to https://github.com/dotnet/runtime/pull/79219/files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but not worth restarting CI, we can update it in a separate PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#112955

<RuntimeIdentifier>wasi-wasm</RuntimeIdentifier>
<WasmSingleFileBundle>true</WasmSingleFileBundle>
<OutputType>Library</OutputType>
Expand Down
Loading