-
Notifications
You must be signed in to change notification settings - Fork 5k
Seed in the skeleton of ML-DSA based on current prototyping #112891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a33e4bc
Seed in the skeleton of ML-DSA based on current prototyping
bartonjs d5c3f03
Suppress IDE0060 in the stub file
bartonjs d89d654
Address feedback
bartonjs f5cda15
Add missing registration of the experimental diagnostic ID
bartonjs 2d23e94
Remove the TryImport methods
bartonjs c36ae48
Leave TODO for Pre-Hash variants
bartonjs 7adf19b
Minor cleanup
bartonjs 3a27c69
Change MLDsaAlgorithm to a class
bartonjs 3f490ee
Respond to feedback
bartonjs 43e1213
Seal MLDsaAlgorithm
bartonjs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
src/libraries/Common/src/System/Security/Cryptography/IImportExportShape.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
namespace System.Security.Cryptography | ||
{ | ||
#if DESIGNTIMEINTERFACES | ||
internal interface IImportExportShape<TSelf> where TSelf : class, IImportExportShape<TSelf> | ||
{ | ||
static abstract TSelf ImportSubjectPublicKeyInfo(ReadOnlySpan<byte> source); | ||
static abstract TSelf ImportPkcs8PrivateKey(ReadOnlySpan<byte> source); | ||
static abstract TSelf ImportEncryptedPkcs8PrivateKey(ReadOnlySpan<byte> passwordBytes, ReadOnlySpan<byte> source); | ||
static abstract TSelf ImportEncryptedPkcs8PrivateKey(ReadOnlySpan<char> password, ReadOnlySpan<byte> source); | ||
|
||
static abstract TSelf ImportFromPem(ReadOnlySpan<char> source); | ||
static abstract TSelf ImportFromEncryptedPem(ReadOnlySpan<char> source, ReadOnlySpan<char> password); | ||
static abstract TSelf ImportFromEncryptedPem(ReadOnlySpan<char> source, ReadOnlySpan<byte> passwordBytes); | ||
|
||
byte[] ExportSubjectPublicKeyInfo(); | ||
bool TryExportSubjectPublicKeyInfo(Span<byte> destination, out int bytesWritten); | ||
string ExportSubjectPublicKeyInfoPem(); | ||
|
||
byte[] ExportPkcs8PrivateKey(); | ||
bool TryExportPkcs8PrivateKey(Span<byte> destination, out int bytesWritten); | ||
string ExportPkcs8PrivateKeyPem(); | ||
|
||
byte[] ExportEncryptedPkcs8PrivateKey(ReadOnlySpan<char> password, PbeParameters pbeParameters); | ||
bool TryExportEncryptedPkcs8PrivateKey( | ||
ReadOnlySpan<char> password, PbeParameters pbeParameters, Span<byte> destination, out int bytesWritten); | ||
string ExportEncryptedPkcs8PrivateKeyPem(ReadOnlySpan<char> password, PbeParameters pbeParameters); | ||
|
||
byte[] ExportEncryptedPkcs8PrivateKey(ReadOnlySpan<byte> passwordBytes, PbeParameters pbeParameters); | ||
bool TryExportEncryptedPkcs8PrivateKey( | ||
ReadOnlySpan<byte> passwordBytes, PbeParameters pbeParameters, Span<byte> destination, out int bytesWritten); | ||
string ExportEncryptedPkcs8PrivateKeyPem(ReadOnlySpan<byte> passwordBytes, PbeParameters pbeParameters); | ||
} | ||
#endif | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this ifdef? This file appears to only be consumed into the S.S.Cryptography.csproj, which sets this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’ll also be consumed in Microsoft.Bcl.Cryptography as the project gets further along