Fix JsonIgnore behavior on init-only properties in source generation mode #112924
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n serializer source generator
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet-policy-service agree |
This was referenced Feb 26, 2025
Open
| @@ -132,5 +155,28 @@ public class Class_PropertyWith_ProtectedInitOnlySetter_WithAttribute | |||
| [JsonInclude] | |||
| public int MyInt { get; protected init; } | |||
| } | |||
|
|
|||
| public class Class_WithIgnoredInitOnlyProperty_WithDefaultValue | |||
There was a problem hiding this comment.
Why is having a default value important in this context? Shouldn't we also be testing for the non-default case?
eiriktsarpalis
added
the
needs-author-action
| @@ -1514,6 +1514,11 @@ private void ProcessMember( | |||
| continue; | |||
| } | |||
|
|
|||
| if (property.DefaultIgnoreCondition == JsonIgnoreCondition.Always && !property.IsRequired) | |||
There was a problem hiding this comment.
We still need to handle ignored required properties somehow, even if we can't remove them from the constructor delegate.
dotnet-policy-service
bot
removed
needs-author-action
This was referenced Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #101877 where the
[JsonIgnore]attribute applied to init-only properties is ignored in source generation mode. In the current behavior, the generated object initializer mistakenly invokes the init for properties marked with[JsonIgnore], which causes the value provided by the constructor to be overwritten (or set to null) during deserialization.