Skip to content

Fix double closing of handle when loading compressed assembly in single-file #113002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix double closing of handle when loading compressed assembly in single-file #113002

merged 1 commit into from
Feb 28, 2025

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Feb 27, 2025 •
edited
Loading

Found this while trying to debug a single-file app with compression. Just running works, since CloseHandle only throws for invalid handles under a debugger.

cc @dotnet/appmodel

@Copilot Copilot AI review requested due to automatic review settings February 27, 2025 22:08
Copilot
Copilot AI reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

@elinor-fung elinor-fung merged commit 04538da into dotnet:main Feb 28, 2025
95 checks passed
@elinor-fung elinor-fung deleted the singleFile-doubleClose branch February 28, 2025 22:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees

@elinor-fung elinor-fung

Labels
area-Single-File
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elinor-fung @AaronRobinsonMSFT