Skip to content

Revert "Switch Ubuntu 24.04 testing to use Ubuntu 22.04 temporarily (#113138)" #113207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

jakobbotsch
Copy link
Member

This reverts commit 9208fb6.

dotnet/dotnet-buildtools-prereqs-docker#1374 was merged and the new images should be available now.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@jakobbotsch jakobbotsch changed the title Revert "Switch Ubuntu 24.04 testing to use Ubuntu 22.04 temporarily (#113138) Revert "Switch Ubuntu 24.04 testing to use Ubuntu 22.04 temporarily (#113138)" Mar 6, 2025
@jakobbotsch jakobbotsch marked this pull request as ready for review March 6, 2025 16:08
@Copilot Copilot AI review requested due to automatic review settings March 6, 2025 16:08
@jakobbotsch
Copy link
Member Author

PTAL @dotnet/runtime-infrastructure

@jakobbotsch jakobbotsch requested a review from a team March 6, 2025 16:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR reverts a previous change to switch Ubuntu testing images back to updated versions based on new available images. Key changes include updating the image tags for Linux arm64 and AMD64 in both the libraries and coreclr pipeline templates.

  • Update Linux arm64 image in libraries from ubuntu-22.04 to ubuntu-24.10.
  • Update Linux AMD64 image in libraries from ubuntu-22.04 to ubuntu-24.04.
  • Update Linux arm64 images in coreclr templates from ubuntu-22.04 to ubuntu-24.04.

Reviewed Changes

File Description
eng/pipelines/libraries/helix-queues-setup.yml Revised image tags for Linux arm64 and AMD64 to new versions.
eng/pipelines/coreclr/templates/helix-queues-setup.yml Updated arm64 image tags to new version for both public and internal pipelines.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

eng/pipelines/coreclr/templates/helix-queues-setup.yml:73

  • The alias indicates 'Ubuntu.2404' while the repository portion still refers to 'Ubuntu.2204'; please verify if all version references should be updated uniformly.
        - (Ubuntu.2404.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-24.04-helix-arm64v8

eng/pipelines/coreclr/templates/helix-queues-setup.yml:75

  • Similar to the previous comment, the version in the alias ('Ubuntu.2404') does not match the repository reference ('Ubuntu.2204'); ensure this is intentional or update for consistency.
        - (Ubuntu.2404.Arm64)[email protected]/dotnet-buildtools/prereqs:ubuntu-24.04-helix-arm64v8

@jakobbotsch jakobbotsch merged commit f63d96e into dotnet:main Mar 6, 2025
118 of 120 checks passed
@jakobbotsch jakobbotsch deleted the revert-image-switch branch March 6, 2025 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants