Delete ObjectNodeSection.IsStandardSection
#113217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This pull request removes the IsStandardSection property from ObjectNodeSection and its dependent GetSharedSection method from ObjectWriter.
- Removed property IsStandardSection from ObjectNodeSection.cs.
- Removed GetSharedSection method from ObjectWriter.cs which depended on the deleted property.
Reviewed Changes
| File | Description |
|---|---|
| src/coreclr/tools/Common/Compiler/DependencyAnalysis/ObjectNodeSection.cs | Removed unused IsStandardSection property. |
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/ObjectWriter.cs | Removed GetSharedSection method that used the deleted property. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
approved these changes
Mar 6, 2025
filipnavara
approved these changes
Mar 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc @dotnet/ilc-contrib