Skip to content

Include xmmintrin.h early on x86 as well #113279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Mar 7, 2025

We're hitting problems with our debugreturn.h machinery on x86 with Clang 20. Include xmmintrin.h early on that platform as well to work around it.

Related: #113248

@Copilot Copilot AI review requested due to automatic review settings March 7, 2025 21:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@am11
Copy link
Member

am11 commented Mar 7, 2025

The other error is:

[ 86%] Linking CXX shared library libDllImportPath_Relative.so
/__w/1/s/src/tests/Interop/DllImportAttribute/DllImportPath/DllImportPathNative.cpp:13:24: error: 'main' should not be 'extern "C"' [-Werror,-Wmain]
   13 | extern "C" int __cdecl main(int argc,  char **argv)
      |                        ^

@richlander
Copy link
Member

Thanks for your help @am11!

@am11
Copy link
Member

am11 commented Mar 8, 2025

@jkoritzinsky I think we can remove extern "C" from this line

extern "C" int __cdecl main(int argc, char **argv)
as part of this PR or a separate one. With that, the builds on 64-bit platforms also succeed.

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkoritzinsky and @am11!

@jkoritzinsky jkoritzinsky merged commit cc01298 into dotnet:main Mar 13, 2025
101 checks passed
@jkoritzinsky jkoritzinsky deleted the x86-xmmintrin branch March 13, 2025 17:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants