Make sure FEATURE_STANDALONE_GC is defined for the usual VM build #113347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc |
janvorli
reviewed
Mar 10, 2025
| @@ -173,6 +173,10 @@ endif(CLR_CMAKE_HOST_WIN32) | |||
| #---------------------------------- | |||
| include(clrdefinitions.cmake) | |||
|
|
|||
| if(FEATURE_STANDALONE_GC) | |||
There was a problem hiding this comment.
The define is added in the gc/CMakeLists.txt, I am not sure I understand why we would need to add it here.
There was a problem hiding this comment.
Ah, I see, I have missed that the define is not used just inside of the GC code, but also in the runtime to enable the code that loads the standalone GC.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.