Skip to content

[release/10.0-preview2] Update dependencies from dotnet/arcade #113381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Updates to .NET SDKs:
    • Updates sdk.version to 10.0.100-preview.3.25125.5
    • Updates tools.dotnet to 10.0.100-preview.3.25125.5

…310.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.25113.2 -> To Version 10.0.0-beta.25160.4
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Mar 11, 2025
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Mar 11, 2025
@carlossanlop
Copy link
Member

How concerning is this error @ericstj @ViktorHofer ?

src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.External.Tests/Microsoft.Extensions.DependencyInjection.ExternalContainers.Tests.csproj(0,0): error NU1510: Warning As Error: PackageReference System.Text.Json will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
❌src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj(0,0): error NU1511: Warning As Error: A ProjectReference cannot be pruned, System.IO.Pipelines.
❌src/libraries/System.Linq.AsyncEnumerable/tests/System.Linq.AsyncEnumerable.Tests.csproj(0,0): error NU1511: Warning As Error: A ProjectReference cannot be pruned, System.Linq.AsyncEnumerable.

@carlossanlop
Copy link
Member

Everything failed with the last commit @lewing :(

@ericstj
Copy link
Member

ericstj commented Mar 12, 2025

Fixed. Hopefully there aren't other changes to take. It looks to me like main never picked up preview1 - it jumped from 10.0.100-alpha.1.25077.2 -> 10.0.100-preview.3.25125.5

@ericstj
Copy link
Member

ericstj commented Mar 12, 2025

Had to rollback to 10.0.100-alpha.1.25077.2. In retrospect this should have been obvious since pruning shipped with P1.

@steveisok steveisok added Servicing-approved Approved for servicing release and removed Servicing-approved Approved for servicing release labels Mar 13, 2025
@mmitche mmitche merged commit c81f403 into release/10.0-preview2 Mar 13, 2025
107 of 162 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-release/10.0-preview2-dc11819e-93e4-4c37-843c-93d00f7e1c7c branch March 13, 2025 17:14
@lewing
Copy link
Member

lewing commented Mar 13, 2025

The thing that is still failing in wbt is that xharness took the arcade sdk and is referencing that. Since xharness doesn't branch for release there isn't an easy way to resolve this here

@akoeplinger
Copy link
Member

I think we could easily fix this by not building xharness for NetCurrent. It really doesn't need to be on the latest TFM.

akoeplinger added a commit to dotnet/xharness that referenced this pull request Mar 13, 2025
We don't need to be on the latest TFM (we already set RollForward=major) and it prevents issues when xharness uses a newer SDK than runtime like in dotnet/runtime#113381 (comment)
ivanpovazan pushed a commit to dotnet/xharness that referenced this pull request Mar 14, 2025
We don't need to be on the latest TFM (we already set RollForward=major) and it prevents issues when xharness uses a newer SDK than runtime like in dotnet/runtime#113381 (comment)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants