[browser] test that Task.Yield yields to browser event loop #113531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
There was a problem hiding this comment.
Pull Request Overview
This PR adds sanity tests to verify that Task.Yield yields control to the browser event loop. Key changes include the introduction of three new tests in YieldAwaitableTests.cs, the implementation of beforeYield, isSetTimeoutHit, and isPromiseThenHit in JavaScriptTestHelper.mjs, and the corresponding JsImport declarations added to JavaScriptTestHelper.cs.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| System/Runtime/InteropServices/JavaScript/YieldAwaitableTests.cs | Adds tests to assert Task.Yield and Task.Delay behavior in the browser event loop |
| System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.mjs | Implements helper functions to track event loop yielding |
| System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.cs | Adds JsImport declarations for the new helper functions |
maraf
approved these changes
Mar 14, 2025
javiercn
approved these changes
Mar 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just sanity tests :)