Skip to content

Enable alljitcommunity in CI #114325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Enable alljitcommunity in CI #114325

merged 2 commits into from
Apr 7, 2025

Conversation

am11
Copy link
Member

@am11 am11 commented Apr 7, 2025

clr.alljitcommunity subset is currently not built in the CI and it frequently breaks on Windows because development of riscv64/loongarch64 is mainly taking place on Unix. Last week, it broke twice: #114062 and #114292. The breakages are mainly due to different analysis warning threshold between llvm and msvc toolchains (explicit casts etc.).

This PR enables it in superpmi CI leg. As to the overhead, it is not too much: before windows-x64 checked took 7m 5s, now it's 8m 2s. Also updated this pipeline to trigger when someone updates its yml configs.

@Copilot Copilot AI review requested due to automatic review settings April 7, 2025 09:48
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 7, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

eng/pipelines/coreclr/superpmi-diffs.yml:58

  • Ensure that the 'clr.alljitscommunity' argument is supported in all targeted environments and that its inclusion does not conflict with existing configurations.
            buildArgs: -s clr.alljits+clr.alljitscommunity+clr.spmi -c $(_BuildConfig)

Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice place to put it. I was thinking about adding it to the main "runtime" job, but this seems simpler and specific to JIT changes.

@BruceForstall BruceForstall merged commit a87fd8b into dotnet:main Apr 7, 2025
103 checks passed
@am11 am11 deleted the patch-31 branch April 7, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants