-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Revert "[release/9.0] Fix edge cases in Tarjan GC bridge (Android)" #114641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- src/tests/GC/Features/Bridge/Bridge.csproj: Language not supported
- src/tests/GC/Features/Bridge/BridgeTester.csproj: Language not supported
Comments suppressed due to low confidence (2)
src/tests/GC/Features/Bridge/BridgeTester.cs:1
- The removal of BridgeTester.cs may reduce test coverage for the GC bridge functionality. Please verify that adequate tests exist elsewhere to validate this behavior.
File removed (BridgeTester.cs)
src/mono/mono/metadata/sgen-tarjan-bridge.c:792
- Replacing 'new_color(FALSE)' with 'reduce_color()' in the non-bridge branch changes the logic for creating a new color. Verify that this change is intentional and that it does not adversely affect the SCC formation behavior.
color_data = reduce_color ();
@carlossanlop ideally this should get in before you branch for servicing. |
Tagging subscribers to this area: @BrzVlad |
Since the original PR was merged on Apr 8 (in other words, it hasn't been released yet), this can be marked as There's a GitHub Copilot review comment. Is that something you want to take or was it an incorrect suggestion? cc @filipnavara |
The suggestion is reverting the revert... in other words, NO. :) It will be fixed once this is resubmitted for next servicing release. |
fyi: this could possily fix the CI crashes we're seeing #114631 |
/ba-g Wasm restarts |
Reverts #114391
I think due to the assertion #114637 is fixing, we revert for now and let main run with the bridge change. I would be ok bringing this back up for servicing next month.