[wasm][interp] Disable PackedSimd operator aliases while we investigate #114659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewing
requested review from
BrzVlad,
kotlarmilos,
steveisok and
vitek-karas
as code owners
ghost
added
the
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
steveisok
approved these changes
Apr 14, 2025
|
it is the shift operators because they have a jiterp fastpath that is missed otherwise. |
|
Proper fix plus some extras in #114669 but will let a few benchmark runs go by before we merge that. |
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a perf regression when enabling them and I would like to avoid regressing preview 4 while still having time to investigate more.