[release/9.0-staging] [wasm] Read messages from binlog if process output is missing build finished message #114676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
|
Tagging subscribers to this area: @akoeplinger, @matouskozak |
This was referenced Apr 15, 2025
Open
This was referenced Apr 15, 2025
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- eng/Versions.props: Language not supported
- src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj: Language not supported
Comments suppressed due to low confidence (2)
src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs:180
- Consider adding test cases to cover scenarios where the process output is replaced with binlog messages to ensure this new logic behaves as expected.
// Ensure we got all output.
src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs:188
- [nitpick] Consider renaming 'buildRoot' to 'binlogRoot' for enhanced clarity that this variable represents the parsed binary log.
var buildRoot = BinaryLog.ReadBuild(logFilePath);
maraf
commented
Apr 16, 2025
Comment on lines
+265
to
+266
| <!-- <SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting> --> | ||
| <SdkVersionForWorkloadTesting>9.0.105</SdkVersionForWorkloadTesting> |
There was a problem hiding this comment.
@akoeplinger Should I merge this in to avoid non-existent 9.0.106 or do we handle it separately?
There was a problem hiding this comment.
yeah we're doing it as part of #114700 too. not sure when that PR will go in.
akoeplinger
approved these changes
Apr 16, 2025
This was referenced Apr 16, 2025
Open
maraf
added
Servicing-approved
|
/ba-g CI failures are unrelated, passed on previous run |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #107280.
Mitigates #106160.
Infrastructure only change.