Skip to content

Implement SVE2 Xor, XorRotateRight #115891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025
Merged

Implement SVE2 Xor, XorRotateRight #115891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f11032
Implement SVE2 Xor, XorRotateRight
snickolls-arm May 20, 2025
c5220e3
Merge branch 'main' of https://github.com/dotnet/runtime into sve2-xor
snickolls-arm May 27, 2025
62d43dd
Remove HW_Category_RotateByImmediate
snickolls-arm May 28, 2025
f1e7524
Remove unnecessary immediate bounds case
snickolls-arm May 29, 2025
53c2201
Remove unnecessary containment case
snickolls-arm Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/coreclr/jit/hwintrinsiccodegenarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2659,6 +2659,7 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
}

case NI_Sve2_BitwiseClearXor:
case NI_Sve2_Xor:
if (targetReg != op1Reg)
{
assert(targetReg != op2Reg && targetReg != op3Reg);
Expand Down
4 changes: 3 additions & 1 deletion src/coreclr/jit/hwintrinsiclistarm64sve.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,9 @@ HARDWARE_INTRINSIC(Sve2, BitwiseSelect,
HARDWARE_INTRINSIC(Sve2, BitwiseSelectLeftInverted, -1, 3, {INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_sve_bsl1n, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_SpecialCodeGen|HW_Flag_HasRMWSemantics)
HARDWARE_INTRINSIC(Sve2, BitwiseSelectRightInverted, -1, 3, {INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_sve_bsl2n, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_SpecialCodeGen|HW_Flag_HasRMWSemantics)
HARDWARE_INTRINSIC(Sve2, ShiftLeftAndInsert, -1, 3, {INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_sve_sli, INS_invalid, INS_invalid}, HW_Category_ShiftLeftByImmediate, HW_Flag_Scalable|HW_Flag_HasImmediateOperand|HW_Flag_HasRMWSemantics)
#define LAST_NI_Sve2 NI_Sve2_ShiftLeftAndInsert
HARDWARE_INTRINSIC(Sve2, Xor, -1, 3, {INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_sve_eor3, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_Scalable|HW_Flag_SpecialCodeGen|HW_Flag_HasRMWSemantics)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remind me, but why we need HW_Flag_SpecialCodeGen for this one? Did you try without adding this flag and what problems we run into?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because the instruction only accepts a D lane arrangement but the intrinsic attempts to pass B/H/S based on the BaseJitType. As it's bitwise it's OK to override it.

Maybe this could be generalized later with more flags to deal with a fixed lane arrangement, or the emitter could just be modified to be smarter about the options passed in. We'd need more space for flags if we wanted to go down the first route. For now I've just used SpecialCodeGen.

HARDWARE_INTRINSIC(Sve2, XorRotateRight, -1, 3, {INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_sve_xar, INS_invalid, INS_invalid}, HW_Category_ShiftRightByImmediate, HW_Flag_Scalable|HW_Flag_HasRMWSemantics|HW_Flag_HasImmediateOperand)
#define LAST_NI_Sve2 NI_Sve2_XorRotateRight

// ***************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
// ISA Function name SIMD size NumArg Instructions Category Flags
Expand Down
102 changes: 102 additions & 0 deletions ...ies/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.PlatformNotSupported.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,5 +280,107 @@ internal Arm64() { }
/// SLI Ztied1.D, Zop2.D, #imm3
/// </summary>
public static Vector<ulong> ShiftLeftAndInsert(Vector<ulong> left, Vector<ulong> right, [ConstantExpected] byte shift) { throw new PlatformNotSupportedException(); }


// Bitwise exclusive OR of three vectors

/// <summary>
/// svuint8_t sveor3[_u8](svuint8_t op1, svuint8_t op2, svuint8_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<byte> Xor(Vector<byte> value1, Vector<byte> value2, Vector<byte> value3) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint16_t sveor3[_s16](svint16_t op1, svint16_t op2, svint16_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<short> Xor(Vector<short> value1, Vector<short> value2, Vector<short> value3) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint32_t sveor3[_s32](svint32_t op1, svint32_t op2, svint32_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<int> Xor(Vector<int> value1, Vector<int> value2, Vector<int> value3) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint64_t sveor3[_s64](svint64_t op1, svint64_t op2, svint64_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<long> Xor(Vector<long> value1, Vector<long> value2, Vector<long> value3) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint8_t sveor3[_s8](svint8_t op1, svint8_t op2, svint8_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<sbyte> Xor(Vector<sbyte> value1, Vector<sbyte> value2, Vector<sbyte> value3) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svuint16_t sveor3[_u16](svuint16_t op1, svuint16_t op2, svuint16_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<ushort> Xor(Vector<ushort> value1, Vector<ushort> value2, Vector<ushort> value3) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svuint32_t sveor3[_u32](svuint32_t op1, svuint32_t op2, svuint32_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<uint> Xor(Vector<uint> value1, Vector<uint> value2, Vector<uint> value3) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svuint64_t sveor3[_u64](svuint64_t op1, svuint64_t op2, svuint64_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<ulong> Xor(Vector<ulong> value1, Vector<ulong> value2, Vector<ulong> value3) { throw new PlatformNotSupportedException(); }


// Bitwise exclusive OR and rotate right

/// <summary>
/// svuint8_t svxar[_n_u8](svuint8_t op1, svuint8_t op2, uint64_t imm3)
/// XAR Ztied1.B, Ztied1.B, Zop2.B, #imm3
/// </summary>
public static Vector<byte> XorRotateRight(Vector<byte> left, Vector<byte> right, [ConstantExpected] byte count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint16_t svxar[_n_s16](svint16_t op1, svint16_t op2, uint64_t imm3)
/// XAR Ztied1.H, Ztied1.H, Zop2.H, #imm3
/// </summary>
public static Vector<short> XorRotateRight(Vector<short> left, Vector<short> right, [ConstantExpected] byte count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint32_t svxar[_n_s32](svint32_t op1, svint32_t op2, uint64_t imm3)
/// XAR Ztied1.S, Ztied1.S, Zop2.S, #imm3
/// </summary>
public static Vector<int> XorRotateRight(Vector<int> left, Vector<int> right, [ConstantExpected] byte count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint64_t svxar[_n_s64](svint64_t op1, svint64_t op2, uint64_t imm3)
/// XAR Ztied1.D, Ztied1.D, Zop2.D, #imm3
/// </summary>
public static Vector<long> XorRotateRight(Vector<long> left, Vector<long> right, [ConstantExpected] byte count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svint8_t svxar[_n_s8](svint8_t op1, svint8_t op2, uint64_t imm3)
/// XAR Ztied1.B, Ztied1.B, Zop2.B, #imm3
/// </summary>
public static Vector<sbyte> XorRotateRight(Vector<sbyte> left, Vector<sbyte> right, [ConstantExpected] byte count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svuint16_t svxar[_n_u16](svuint16_t op1, svuint16_t op2, uint64_t imm3)
/// XAR Ztied1.H, Ztied1.H, Zop2.H, #imm3
/// </summary>
public static Vector<ushort> XorRotateRight(Vector<ushort> left, Vector<ushort> right, [ConstantExpected] byte count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svuint32_t svxar[_n_u32](svuint32_t op1, svuint32_t op2, uint64_t imm3)
/// XAR Ztied1.S, Ztied1.S, Zop2.S, #imm3
/// </summary>
public static Vector<uint> XorRotateRight(Vector<uint> left, Vector<uint> right, [ConstantExpected] byte count) { throw new PlatformNotSupportedException(); }

/// <summary>
/// svuint64_t svxar[_n_u64](svuint64_t op1, svuint64_t op2, uint64_t imm3)
/// XAR Ztied1.D, Ztied1.D, Zop2.D, #imm3
/// </summary>
public static Vector<ulong> XorRotateRight(Vector<ulong> left, Vector<ulong> right, [ConstantExpected] byte count) { throw new PlatformNotSupportedException(); }
}
}
102 changes: 102 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,5 +280,107 @@ internal Arm64() { }
/// SLI Ztied1.D, Zop2.D, #imm3
/// </summary>
public static Vector<ulong> ShiftLeftAndInsert(Vector<ulong> left, Vector<ulong> right, [ConstantExpected] byte shift) => ShiftLeftAndInsert(left, right, shift);


// Bitwise exclusive OR of three vectors

/// <summary>
/// svuint8_t sveor3[_u8](svuint8_t op1, svuint8_t op2, svuint8_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<byte> Xor(Vector<byte> value1, Vector<byte> value2, Vector<byte> value3) => Xor(value1, value2, value3);

/// <summary>
/// svint16_t sveor3[_s16](svint16_t op1, svint16_t op2, svint16_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<short> Xor(Vector<short> value1, Vector<short> value2, Vector<short> value3) => Xor(value1, value2, value3);

/// <summary>
/// svint32_t sveor3[_s32](svint32_t op1, svint32_t op2, svint32_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<int> Xor(Vector<int> value1, Vector<int> value2, Vector<int> value3) => Xor(value1, value2, value3);

/// <summary>
/// svint64_t sveor3[_s64](svint64_t op1, svint64_t op2, svint64_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<long> Xor(Vector<long> value1, Vector<long> value2, Vector<long> value3) => Xor(value1, value2, value3);

/// <summary>
/// svint8_t sveor3[_s8](svint8_t op1, svint8_t op2, svint8_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<sbyte> Xor(Vector<sbyte> value1, Vector<sbyte> value2, Vector<sbyte> value3) => Xor(value1, value2, value3);

/// <summary>
/// svuint16_t sveor3[_u16](svuint16_t op1, svuint16_t op2, svuint16_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<ushort> Xor(Vector<ushort> value1, Vector<ushort> value2, Vector<ushort> value3) => Xor(value1, value2, value3);

/// <summary>
/// svuint32_t sveor3[_u32](svuint32_t op1, svuint32_t op2, svuint32_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<uint> Xor(Vector<uint> value1, Vector<uint> value2, Vector<uint> value3) => Xor(value1, value2, value3);

/// <summary>
/// svuint64_t sveor3[_u64](svuint64_t op1, svuint64_t op2, svuint64_t op3)
/// EOR3 Ztied1.D, Ztied1.D, Zop2.D, Zop3.D
/// </summary>
public static Vector<ulong> Xor(Vector<ulong> value1, Vector<ulong> value2, Vector<ulong> value3) => Xor(value1, value2, value3);


// Bitwise exclusive OR and rotate right

/// <summary>
/// svuint8_t svxar[_n_u8](svuint8_t op1, svuint8_t op2, uint64_t imm3)
/// XAR Ztied1.B, Ztied1.B, Zop2.B, #imm3
/// </summary>
public static Vector<byte> XorRotateRight(Vector<byte> left, Vector<byte> right, [ConstantExpected] byte count) => XorRotateRight(left, right, count);

/// <summary>
/// svint16_t svxar[_n_s16](svint16_t op1, svint16_t op2, uint64_t imm3)
/// XAR Ztied1.H, Ztied1.H, Zop2.H, #imm3
/// </summary>
public static Vector<short> XorRotateRight(Vector<short> left, Vector<short> right, [ConstantExpected] byte count) => XorRotateRight(left, right, count);

/// <summary>
/// svint32_t svxar[_n_s32](svint32_t op1, svint32_t op2, uint64_t imm3)
/// XAR Ztied1.S, Ztied1.S, Zop2.S, #imm3
/// </summary>
public static Vector<int> XorRotateRight(Vector<int> left, Vector<int> right, [ConstantExpected] byte count) => XorRotateRight(left, right, count);

/// <summary>
/// svint64_t svxar[_n_s64](svint64_t op1, svint64_t op2, uint64_t imm3)
/// XAR Ztied1.D, Ztied1.D, Zop2.D, #imm3
/// </summary>
public static Vector<long> XorRotateRight(Vector<long> left, Vector<long> right, [ConstantExpected] byte count) => XorRotateRight(left, right, count);

/// <summary>
/// svint8_t svxar[_n_s8](svint8_t op1, svint8_t op2, uint64_t imm3)
/// XAR Ztied1.B, Ztied1.B, Zop2.B, #imm3
/// </summary>
public static Vector<sbyte> XorRotateRight(Vector<sbyte> left, Vector<sbyte> right, [ConstantExpected] byte count) => XorRotateRight(left, right, count);

/// <summary>
/// svuint16_t svxar[_n_u16](svuint16_t op1, svuint16_t op2, uint64_t imm3)
/// XAR Ztied1.H, Ztied1.H, Zop2.H, #imm3
/// </summary>
public static Vector<ushort> XorRotateRight(Vector<ushort> left, Vector<ushort> right, [ConstantExpected] byte count) => XorRotateRight(left, right, count);

/// <summary>
/// svuint32_t svxar[_n_u32](svuint32_t op1, svuint32_t op2, uint64_t imm3)
/// XAR Ztied1.S, Ztied1.S, Zop2.S, #imm3
/// </summary>
public static Vector<uint> XorRotateRight(Vector<uint> left, Vector<uint> right, [ConstantExpected] byte count) => XorRotateRight(left, right, count);

/// <summary>
/// svuint64_t svxar[_n_u64](svuint64_t op1, svuint64_t op2, uint64_t imm3)
/// XAR Ztied1.D, Ztied1.D, Zop2.D, #imm3
/// </summary>
public static Vector<ulong> XorRotateRight(Vector<ulong> left, Vector<ulong> right, [ConstantExpected] byte count) => XorRotateRight(left, right, count);
}
}
16 changes: 16 additions & 0 deletions src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6079,6 +6079,22 @@ internal Arm64() { }
public static System.Numerics.Vector<ushort> ShiftLeftAndInsert(System.Numerics.Vector<ushort> left, System.Numerics.Vector<ushort> right, [ConstantExpected] byte shift) { throw null; }
public static System.Numerics.Vector<uint> ShiftLeftAndInsert(System.Numerics.Vector<uint> left, System.Numerics.Vector<uint> right, [ConstantExpected] byte shift) { throw null; }
public static System.Numerics.Vector<ulong> ShiftLeftAndInsert(System.Numerics.Vector<ulong> left, System.Numerics.Vector<ulong> right, [ConstantExpected] byte shift) { throw null; }
public static System.Numerics.Vector<byte> Xor(System.Numerics.Vector<byte> value1, System.Numerics.Vector<byte> value2, System.Numerics.Vector<byte> value3) { throw null; }
public static System.Numerics.Vector<short> Xor(System.Numerics.Vector<short> value1, System.Numerics.Vector<short> value2, System.Numerics.Vector<short> value3) { throw null; }
public static System.Numerics.Vector<int> Xor(System.Numerics.Vector<int> value1, System.Numerics.Vector<int> value2, System.Numerics.Vector<int> value3) { throw null; }
public static System.Numerics.Vector<long> Xor(System.Numerics.Vector<long> value1, System.Numerics.Vector<long> value2, System.Numerics.Vector<long> value3) { throw null; }
public static System.Numerics.Vector<sbyte> Xor(System.Numerics.Vector<sbyte> value1, System.Numerics.Vector<sbyte> value2, System.Numerics.Vector<sbyte> value3) { throw null; }
public static System.Numerics.Vector<ushort> Xor(System.Numerics.Vector<ushort> value1, System.Numerics.Vector<ushort> value2, System.Numerics.Vector<ushort> value3) { throw null; }
public static System.Numerics.Vector<uint> Xor(System.Numerics.Vector<uint> value1, System.Numerics.Vector<uint> value2, System.Numerics.Vector<uint> value3) { throw null; }
public static System.Numerics.Vector<ulong> Xor(System.Numerics.Vector<ulong> value1, System.Numerics.Vector<ulong> value2, System.Numerics.Vector<ulong> value3) { throw null; }
public static System.Numerics.Vector<byte> XorRotateRight(System.Numerics.Vector<byte> left, System.Numerics.Vector<byte> right, [ConstantExpected] byte count) { throw null; }
public static System.Numerics.Vector<short> XorRotateRight(System.Numerics.Vector<short> left, System.Numerics.Vector<short> right, [ConstantExpected] byte count) { throw null; }
public static System.Numerics.Vector<int> XorRotateRight(System.Numerics.Vector<int> left, System.Numerics.Vector<int> right, [ConstantExpected] byte count) { throw null; }
public static System.Numerics.Vector<long> XorRotateRight(System.Numerics.Vector<long> left, System.Numerics.Vector<long> right, [ConstantExpected] byte count) { throw null; }
public static System.Numerics.Vector<sbyte> XorRotateRight(System.Numerics.Vector<sbyte> left, System.Numerics.Vector<sbyte> right, [ConstantExpected] byte count) { throw null; }
public static System.Numerics.Vector<ushort> XorRotateRight(System.Numerics.Vector<ushort> left, System.Numerics.Vector<ushort> right, [ConstantExpected] byte count) { throw null; }
public static System.Numerics.Vector<uint> XorRotateRight(System.Numerics.Vector<uint> left, System.Numerics.Vector<uint> right, [ConstantExpected] byte count) { throw null; }
public static System.Numerics.Vector<ulong> XorRotateRight(System.Numerics.Vector<ulong> left, System.Numerics.Vector<ulong> right, [ConstantExpected] byte count) { throw null; }
}

public enum SveMaskPattern : byte
Expand Down
Loading
Loading