Skip to content

Revert "Pin build container SHAs" #116116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Revert "Pin build container SHAs" #116116

merged 2 commits into from
May 30, 2025

Conversation

richlander
Copy link
Member

Reverts #116083

The new images are now available.

@Copilot Copilot AI review requested due to automatic review settings May 29, 2025 21:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Reverts the previous pinning of container image SHAs to allow usage of the latest prereqs images now that updated images are available.

  • Removed hardcoded digests from all prereqs image references.
  • Restores reliance on tag-based image resolution for cross-build containers.
Comments suppressed due to low confidence (1)

eng/pipelines/common/templates/pipeline-with-resources.yml:20

  • Reverting to mutable image tags removes build reproducibility and can introduce potential security risks. Consider pinning images to a digest or immutable tag to ensure consistent and secure builds.
image: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net10.0-cross-arm

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CI is green

@richlander richlander merged commit 35cb2d7 into main May 30, 2025
148 of 150 checks passed
@jkotas jkotas deleted the revert-116083-pin-shas branch May 31, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants