[browser][WBT] fix BlazorEventPipeTestWithMetrics test #116334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
There was a problem hiding this comment.
Pull Request Overview
This PR enables event source and metrics support in the BlazorEventPipe test and cleans up repetitive assertions by using loops over expected items.
- Adds
<EventSourceSupport>and<MetricsSupport>flags to the test project properties. - Refactors long chains of
Assert.Truecalls into loops over expected-instrument and expected-event arrays.
Comments suppressed due to low confidence (1)
src/mono/wasm/Wasm.Build.Tests/Blazor/EventPipeDiagnosticsTests.cs:210
- The assertion message still references "metrics.nettrace", but this block is validating events from "gcdump.nettrace". Update the message to reflect the correct trace type.
Assert.True(actualEvents.ContainsKey(expectedEvent), $"The metrics.nettrace should contain event: {expectedEvent}");
akoeplinger
approved these changes
Jun 5, 2025
maraf
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116303
<EventSourceSupport>true</EventSourceSupport><MetricsSupport>true</MetricsSupport>to the test.