Make ETW rundown operate more effectively with JIT

[AaronRobinsonMSFT]

Fixes #102858

Make the EECodeGenManager API surface narrower.
Rename some locals removing critical section notion and replace with lock.

Rework the CodeHeapIterator.
Rename members to more accurately reflect their purpose. Generally move to more canonical C++.

EECodeGenManager now has an iterator counter. This is used to track the number of outstanding iterators and can be used to defer deletes. Adds are still valid since the iterator will only operate on the state at the time the iterator was created.

Always emit UnwindInfo for methods. This was previously only enabled when the Runtime provider was enabled and a rundown triggered.

[Copilot]

Pull Request Overview

This PR refines the ETW rundown and JIT-related code by narrowing the EECodeGenManager API, renaming variables and functions for improved clarity, and reworking the CodeHeapIterator. It also updates logging formats, modifies type usage for iteration counters, and adjusts several low‐level components to support the new design.

• Refactored API calls (e.g. AllocCode, AllocFromJitMetaHeap) and adapted braced initialization for RemoveJitData.
• Renamed members (e.g. m_pChunks → m_pChunksBegin) and updated iteration variable types (USHORT → INT32) for consistency.
• Improved log formatting and introduced move semantics in CrstHolder for better concurrency safety.

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/coreclr/vm/jitinterface.cpp	Updated API calls and braced initialization for RemoveJitData.
src/coreclr/vm/excep.cpp	Changed iteration counter types from USHORT to INT32.
src/coreclr/vm/eventtrace.cpp	Modified event logging flow and adjusted the code heap iterator usage.
src/coreclr/vm/dynamicmethod.{h,cpp}	Added new setters and updated LOG formatting.
src/coreclr/vm/crst.h	Added move semantics to CrstHolder for improved lock management.
src/coreclr/vm/codeman.h	Renamed members and updated virtual destructors to default.
src/coreclr/vm/class.{inl,h,cpp}	Renamed chunk pointers to improve clarity of the method list.
src/coreclr/utilcode/{pedecoder.cpp,pedecoder.h}	Adjusted MethodSectionIterator to use non-const pointers.
src/coreclr/inc/utilcode.h	Updated the type for Count() from USHORT to INT32.
src/coreclr/inc/contract.inl	Revised error message text for tracking failures.
src/coreclr/debug/daccess/*	Updated references to use the new m_pAllCodeHeaps naming.

Comments suppressed due to low confidence (6)

src/coreclr/vm/dynamicmethod.cpp:876

• The updated LOG formatting now uses '%zx' for size_t values; please verify that this format specifier is supported on all target platforms.

LOG((LF_BCL, LL_INFO1000, "Level3 - CodeHeap released [%p, vt(0x%zx)] - ref count %d\n", this, *(size_t*)this, m_AllocationCount));

src/coreclr/utilcode/pedecoder.cpp:2581

• The removal of const qualifiers from the MethodSectionIterator parameters changes the method's contract; please confirm that allowing mutation on these pointers is intentional and safe for the overall design.

MethodSectionIterator::MethodSectionIterator(void *code, SIZE_T codeSize, void *codeTable, SIZE_T codeTableSize)

src/coreclr/inc/contract.inl:588

• The updated error message provides clearer information regarding missing tracking data; please ensure that this change is consistently reflected in related documentation and error handling conventions.

strcat_s(Buf,ARRAY_SIZE(Buf), "Missing tracking information. Look for data structures that manipulate contract state (i.e., CrstHolder).\n");

src/coreclr/vm/jitinterface.cpp:11044

• The use of braced initialization for RemoveJitData is nontraditional; please double-check that overload resolution works as intended across all build configurations.

jitMgr->RemoveJitData({pCodeHeader, m_GCinfo_len, m_EHinfo_len});

src/coreclr/inc/utilcode.h:1095

• Changing the return type of Count() from USHORT to INT32 is fine, but please ensure that all dependent functions and loops consuming this value are updated to handle INT32 appropriately.

INT32 Count()

src/coreclr/vm/crst.h:371

• The introduction of move semantics for CrstHolder is a good improvement; please verify that the new move constructor and assignment operator correctly preserve lock invariants in all multi-threaded scenarios.

CrstHolder(CrstHolder&& other)

[jkotas]

Test failures look related:

20:03:09.305 Running test: tracing/runtimeeventsource/nativeruntimeeventsource/nativeruntimeeventsource.cmd
ASSERT FAILED
	Expression: codeLength > 0
	Location:   line 1866 in /Users/runner/work/1/s/src/coreclr/vm/eetwain.cpp

[AaronRobinsonMSFT]

Test failures look related:

20:03:09.305 Running test: tracing/runtimeeventsource/nativeruntimeeventsource/nativeruntimeeventsource.cmd
ASSERT FAILED
	Expression: codeLength > 0
	Location:   line 1866 in /Users/runner/work/1/s/src/coreclr/vm/eetwain.cpp

Yep. I'm trying to root it out on macOS. I tried on Windows and did find a contract violation that I needed to fix. I pushed up that fix and will see where we are.

[AaronRobinsonMSFT]

@jkotas I think this should be ready to review now.