[wasm] Consolidate native build logic for WASM #116390
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
SingleAccretion
commented
Jun 7, 2025
|
|
||
| set __ExtraCmakeParams=%__ExtraCmakeParams% "-DCMAKE_TOOLCHAIN_FILE=!EMSDK_PATH!/emscripten/cmake/Modules/Platform/Emscripten.cmake" | ||
| set __UseEmcmake=1 | ||
| set EMSDK_QUIET=1 && call !EMSDK_PATH!/emsdk_env |
There was a problem hiding this comment.
Any opinions on EMSDK_QUIET? Windows was "quiet", not-Windows was "shouty", I made them both "quiet" because emsdk_env prints the full PATH. But I can very easily be convinced it's better to be more verbose with this thing.
|
Tagging subscribers to 'arch-wasm': @lewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the Windows and not-Windows logic match; remove unnecessary arguments.