Fix stresslog facility and log level mix-up. #116467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of commit: dotnet@6bd555e some stress log macro implementations got changed, but the call to StressLog::LogMsg in gcenv.h and stresslog.h got level and facility arguments switched, leading to no logging when these macros are used. Fix restore the order of the level and facility arguments in call to StressLog::LogMsg.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the logging issue by restoring the correct order of the level and facility arguments when calling StressLog::LogMsg.
- The argument order in the stress log macro in stresslog.h is corrected.
- The argument order for StressLog::LogMsg in gcenv.h is similarly updated.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/inc/stresslog.h | Corrected argument order to properly pass log level and facility. |
| src/coreclr/gc/env/gcenv.h | Adjusted argument order to ensure StressLog::LogMsg receives parameters in the correct order. |
Comments suppressed due to low confidence (2)
src/coreclr/inc/stresslog.h:78
- Ensure that the new parameter order (log level first, then facility) aligns with the StressLog::LogMsg implementation and intended usage.
StressLog::LogMsg(level, facility, 0, msg);
src/coreclr/gc/env/gcenv.h:60
- Verify that passing the log level before the facility is correct for the StressLog::LogMsg API to restore proper logging functionality.
StressLog::LogMsg(level, facility, StressLogMsg(msg, __VA_ARGS__));
|
Tagging subscribers to this area: @dotnet/gc |
Maoni0
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of commit:
6bd555e
some stress log macro implementations got changed, but the call to StressLog::LogMsg in gcenv.h and stresslog.h got level and facility arguments switched, leading to no logging when these macros are used.
PR restore the order of the level and facility arguments in call to StressLog::LogMsg.