[cDAC] ARM Stackwalking #116645
Open
[cDAC] ARM Stackwalking #116645
+1,547
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
This was referenced Jun 13, 2025
max-charlamb
requested review from
Copilot,
steveisok,
jkotas,
davidwrighton and
tommcdon
There was a problem hiding this comment.
Pull Request Overview
This PR adds ARM stackwalking support by introducing an ARM-specific unwinder, context, and frame handler along with associated type descriptor and documentation updates. The key changes include:
- Implementation of ARMUnwinder, ARMContext, and ARMFrameHandler to support ARM stackwalking.
- Updates to the InlinedCallFrame to include the new SPAfterProlog field for ARM.
- Adjustments to data descriptors and documentation to accommodate ARM32 specifics.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/Frames/InlinedCallFrame.cs | Adds SPAfterProlog field initialization for ARM. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/FrameIterator.cs | Introduces ARM frame handling by mapping ARMContext to ARMFrameHandler. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/ARMFrameHandler.cs | Implements ARM specific handling for inlined call frames and faulting exception frames. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/Context/ARMContext.cs | Provides a full ARM-specific context struct implementation. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/Context/ARM/LookupValues.cs | Introduces lookup tables using modern collection initialization syntax. |
| src/coreclr/debug/runtimeinfo/datadescriptor.h | Adds ARM-specific type definitions for the DAC. |
| docs/design/datacontracts/StackWalk.md | Updates documentation to describe the new SPAfterProlog field for ARM. |
.../cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/Context/M128.cs
Outdated
Show resolved
Hide resolved
…er.Contracts/Contracts/StackWalk/Context/M128.cs Co-authored-by: Copilot <[email protected]>
This was referenced Jun 19, 2025
This was referenced Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
IStackWalk
ARMUnwinderARMFrameHandlerSPAfterPrologGeneral ARM32 conversion fixes
Changes done in separate PR: #116720
DAC GetThreadData properly convertsfirstNestedExceptionto aCLRDATA_ADDRESSCodePointerUtils.CodePointerFromAddressproperly handlesTargetCodePointer.Nullcase. Previously it would append the thumb bit causing logic checks to fail.