Skip to content

Disable System.Runtime.InteropServices.JavaScript.Tests on Windows #116734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jun 17, 2025

Active issue: #116695. Disable until fix is found, the hit count is very high.

@ilonatommy ilonatommy requested a review from maraf June 17, 2025 10:58
@ilonatommy ilonatommy self-assigned this Jun 17, 2025
@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 10:58
@ilonatommy ilonatommy added the arch-wasm WebAssembly architecture label Jun 17, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the System.Runtime.InteropServices.JavaScript tests on Windows until the underlying issue is resolved.

  • Disables the project by adding a conditional exclusion for the tests on Windows when running in the browser target in CI.
  • Adds an active issue comment to flag the missing dev cert on Windows.
Comments suppressed due to low confidence (1)

src/libraries/tests.proj:43

  • The active issue number in this comment (116695) differs from the PR metadata (116685). Please verify and update the issue number to ensure consistency.
<!-- ActiveIssue https://github.com/dotnet/runtime/issues/116695 missing dev cert on Windows -->

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 17, 2025
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@ilonatommy
Copy link
Member Author

/ba-g Failures are not related.

browser-wasm windows Debug AllSubsets_CoreCLR is #116746, it was not caught due to new line between line with FAILED and CMakeFiles:

 FAILED: test-watchdog/watchdog.js 
  C:\Windows\system32\cmd.exe /C "cd . && D:\a\_work\1\s\src\mono\browser\emsdk\emscripten\em++.bat -O3 -DNDEBUG  test-watchdog/CMakeFiles/watchdog.dir/watchdog.cpp.o test-watchdog/CMakeFiles/watchdog.dir/D_/a/_work/1/s/artifacts/obj/_version.c.o -o test-watchdog\watchdog.js   && cd ."

log

System.Runtime.Tests do not have logs but also cannot be related: https://dotnet.github.io/core-eng/helix-workitem-deadletter.txt

@ilonatommy ilonatommy requested a review from akoeplinger June 18, 2025 12:03
@ilonatommy ilonatommy merged commit 5951ad2 into dotnet:main Jun 18, 2025
83 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants