Remove Assert in Method.MakeGeneric on Invalid Arg #116788
Open
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
mono_class_inflate_generic_method_checked
will set error when there are invalid types (e.g.typeof(void)
/typeof(int*))
passed in. This should not be an assert, we should fall to the "Invalid generic arguments" message below. This does loose the error returned bymono_class_inflate_generic_method_checked
but that error isn't userfriendly. It would report be something like:
Instead report the more general/readable error to the user.
Fix: #71339.
Repo:
Result Before:
Result After: