Arm64 SVE: re-enable use of predicate variants #116854
Open
+447
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#101970 in dotnet#115566 Adds a simple costing to fgMorphTryUseAllMaskVariant() and assumes nodes can always be converted to masks (using ConvertVectorToMask).
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
a74nh
commented
Jun 20, 2025
| @@ -1993,6 +1993,104 @@ SveMaskPattern EvaluateSimdMaskToPattern(var_types baseType, simdmask_t arg0) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| template <typename TSimd, typename TBase> | |||
There was a problem hiding this comment.
Same changes to this file also exist in #116852. I'll remove from one PR when the other is merged.
| // depending on if the corresponding input element | ||
| // has its least significant bit set | ||
|
|
||
| bool isSet = static_cast<uint64_t>(1) << (i * sizeof(TBase)); |
There was a problem hiding this comment.
as I pointed in other PR, this one doesn't even check with contents of input0.
| // Arguments: | ||
| // node - The node to convert to a mask | ||
| // parent - The parent of the node | ||
| // currentCost - (IN/OUT) incremented by the current cost of the node |
There was a problem hiding this comment.
nit: just for better readability, consider renaming currentCost and switchCost to something meaningful like maskToVectorConvertCost and vectorToMaskConvertCost.
| static constexpr const weight_t costOfConvertMaskToVector = 1.0; | ||
|
|
||
| // Conversion of vector to mask is two instructions. | ||
| static constexpr const weight_t costOfConvertVectorToMask = 2.0; |
There was a problem hiding this comment.
add a comment on why costOfConvertVectorToMask is expensive than costOfConvertMaskToVector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101970
Predicate variants were implemented, and then turned off in #115566.
Adds a simple costing to fgMorphTryUseAllMaskVariant() and assumes nodes can always be converted to masks (using ConvertVectorToMask).