Misc. illumous build fixes (prereq. for #105403) #117023

gwr · 2025-06-25T15:08:49Z

Co-authored-by: Adeel Mujahid [email protected]

Workaround Bootstrap is failing on platform without AOT support #116929 Update eng/Subsets.props
Fix compile error at minipal/debugger.c:127

dotnet/runtime/src/native/minipal/debugger.c:127:5: error: implicit declaration of function 'snprintf' [-Werror=implicit-function-declaration]
127 | snprintf(statusFilename, sizeof(statusFilename), "/proc/%d/status", getpid());
| ^~~~~~~~
Fix compile error in minipal/thread.h

src/native/minipal/thread.h:73:23: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
73 | tid = (size_t)(void*)pthread_self();
| ^~~~~~~~~~~~~~~~~~~~~
Fix compile error in native/libs/System.Native/pal_mount.c

src/native/libs/System.Native/pal_mount.c:164:38: error: 'struct statvfs' has no member named 'f_type'
164 | *formatType = (int64_t)(stats.f_type);
| ^

Fix compile error in coreclr/pal/src/thread/thread.cpp

/home/gwr/dotnet/runtime/src/coreclr/pal/src/thread/thread.cpp:1367:5: error: 'cid' was not declared in this scope
1367 | cid = CLOCK_THREAD_CPUTIME_ID;
| ^~~
Fix compile error in coreclr/vm/appdomain.hpp

src/coreclr/vm/appdomain.hpp:1934:40: error: declaration of 'constexpr SystemDomain** const cdac_data::SystemDomain' changes meaning of 'SystemDomain' [-Wchanges-meaning]
1934 | static constexpr PTR_SystemDomain* SystemDomain = &SystemDomain::m_pSystemDomain;
| ^~~~~~~~~~~~
src/coreclr/vm/appdomain.hpp:1934:56: note: used here to mean 'class SystemDomain'
1934 | static constexpr PTR_SystemDomain* SystemDomain = &SystemDomain::m_pSystemDomain;
| ^~~~~~~~~~~~
src/coreclr/vm/appdomain.hpp:1629:7: note: declared here
1629 | class SystemDomain final
| ^~~~~~~~~~~~

Fix compile error in coreclr/runtime/amd64/AllocFast.S

coreclr/runtime/amd64/AllocFast.S: Assembler messages:
coreclr/runtime/amd64/AllocFast.S:237: Error: missing ')'

Add HAVE_DIRENT_D_TYPE introspection
Fix compile errors in coreclr/tools/superpmi/mcs/verbmerge.cpp

/runtime/src/coreclr/tools/superpmi/mcs/verbmerge.cpp: In static member function 'static bool verbMerge::DirectoryFilterDirectories(FilterArgType*)': /runtime/src/coreclr/tools/superpmi/mcs/verbmerge.cpp:188:19: error: 'verbMerge::FilterArgType' {aka 'struct dirent'} has no member named 'd_type'
188 | if (findData->d_type == DT_DIR)
| ^~~~~~

and similar a few other places in this file

Let FilterArgType use struct FindData to simplify filters.
Handle the possibility of finding d_type == DT_UNKOWN

Update eng/Subsets.props Co-authored-by: Adeel Mujahid <[email protected]>

dotnet/runtime/src/native/minipal/debugger.c:127:5: error: implicit declaration of function 'snprintf' [-Werror=implicit-function-declaration] 127 | snprintf(statusFilename, sizeof(statusFilename), "/proc/%d/status", getpid()); | ^~~~~~~~

src/native/minipal/thread.h:73:23: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 73 | tid = (size_t)(void*)pthread_self(); | ^~~~~~~~~~~~~~~~~~~~~

src/native/libs/System.Native/pal_mount.c:164:38: error: 'struct statvfs' has no member named 'f_type' 164 | *formatType = (int64_t)(stats.f_type); | ^

/home/gwr/dotnet/runtime/src/coreclr/pal/src/thread/thread.cpp:1367:5: error: 'cid' was not declared in this scope 1367 | cid = CLOCK_THREAD_CPUTIME_ID; | ^~~

src/coreclr/vm/appdomain.hpp:1934:40: error: declaration of 'constexpr SystemDomain** const cdac_data<SystemDomain>::SystemDomain' changes meaning of 'SystemDomain' [-Wchanges-meaning] 1934 | static constexpr PTR_SystemDomain* SystemDomain = &SystemDomain::m_pSystemDomain; | ^~~~~~~~~~~~ src/coreclr/vm/appdomain.hpp:1934:56: note: used here to mean 'class SystemDomain' 1934 | static constexpr PTR_SystemDomain* SystemDomain = &SystemDomain::m_pSystemDomain; | ^~~~~~~~~~~~ src/coreclr/vm/appdomain.hpp:1629:7: note: declared here 1629 | class SystemDomain final | ^~~~~~~~~~~~

src/coreclr/runtime/amd64/AllocFast.S

on illumos with gcc 13.3 cross copmiler coreclr/runtime/amd64/AllocFast.S: Assembler messages: coreclr/runtime/amd64/AllocFast.S:237: Error: missing ')'

gwr · 2025-06-25T17:56:06Z

I'm keeping the commits in this PR separately for now as that's easier for my local work.
I'll happily squash this all once people are happy with the changes.

src/native/libs/Common/pal_config.h.in

am11 · 2025-06-25T18:19:30Z

I'll happily squash this all once people are happy with the changes.

Repo maintainers can squash on merge (GitHub merge button has that option).

jkotas · 2025-06-25T18:24:03Z

src/coreclr/tools/superpmi/mcs/verbmerge.cpp

@@ -281,12 +288,47 @@ int verbMerge::FilterDirectory(LPCWSTR                      dir,
        dirent *pEntry = readdir(pDir);
        while (pEntry != nullptr)
        {
-            if ((fnmatch(searchPatternUtf8.c_str(), pEntry->d_name, 0) == 0) && filter(pEntry))
+            int dirEntryType;


@dotnet/jit-contrib Could you please review the superpmi changes?

dotnet-policy-service · 2025-06-26T12:29:02Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

/runtime/src/coreclr/tools/superpmi/mcs/verbmerge.cpp: In static member function 'static bool verbMerge::DirectoryFilterDirectories(FilterArgType*)': /runtime/src/coreclr/tools/superpmi/mcs/verbmerge.cpp:188:19: error: 'verbMerge::FilterArgType' {aka 'struct dirent'} has no member named 'd_type' 188 | if (findData->d_type == DT_DIR) | ^~~~~~ and similar a few other places in this file Let FilterArgType use struct FindData to simplify filters. Handle the possibility of finding d_type == DT_UNKOWN

gwr · 2025-07-02T01:37:32Z

Needs approvers. @am11 ?

am11 and others added 6 commits June 24, 2025 13:39

Workaround dotnetgh-116929

3eb1120

Update eng/Subsets.props Co-authored-by: Adeel Mujahid <[email protected]>

Fix compile error at minipal/debugger.c:127

0e7fc39

dotnet/runtime/src/native/minipal/debugger.c:127:5: error: implicit declaration of function 'snprintf' [-Werror=implicit-function-declaration] 127 | snprintf(statusFilename, sizeof(statusFilename), "/proc/%d/status", getpid()); | ^~~~~~~~

Fix compile error in minipal/thread.h

5a2484a

src/native/minipal/thread.h:73:23: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 73 | tid = (size_t)(void*)pthread_self(); | ^~~~~~~~~~~~~~~~~~~~~

Fix compile error in native/libs/System.Native/pal_mount.c

7159246

src/native/libs/System.Native/pal_mount.c:164:38: error: 'struct statvfs' has no member named 'f_type' 164 | *formatType = (int64_t)(stats.f_type); | ^

Fix compile error in coreclr/pal/src/thread/thread.cpp

1487ab7

/home/gwr/dotnet/runtime/src/coreclr/pal/src/thread/thread.cpp:1367:5: error: 'cid' was not declared in this scope 1367 | cid = CLOCK_THREAD_CPUTIME_ID; | ^~~

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 25, 2025

github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 25, 2025

gwr commented Jun 25, 2025

View reviewed changes

src/coreclr/runtime/amd64/AllocFast.S Outdated Show resolved Hide resolved

gwr and others added 2 commits June 25, 2025 13:51

Fix compile error in coreclr/runtime/amd64/AllocFast.S

93235eb

on illumos with gcc 13.3 cross copmiler coreclr/runtime/amd64/AllocFast.S: Assembler messages: coreclr/runtime/amd64/AllocFast.S:237: Error: missing ')'

Add HAVE_DIRENT_D_TYPE introspection

5b45418

gwr force-pushed the illumos4e branch from 4595e44 to d7f655d Compare June 25, 2025 17:53

jkotas reviewed Jun 25, 2025

View reviewed changes

src/native/libs/Common/pal_config.h.in Show resolved Hide resolved

jkotas reviewed Jun 25, 2025

View reviewed changes

am11 removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 26, 2025

am11 added arch-x64 area-Infrastructure-coreclr os-SunOS SunOS, currently not officially supported labels Jun 26, 2025

github-project-automation bot added this to Runtime Infra Jun 26, 2025

gwr mentioned this pull request Jun 27, 2025

SunOS process and thread support #117098

Closed

gwr force-pushed the illumos4e branch from d7f655d to 97fe413 Compare June 28, 2025 10:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Misc. illumous build fixes (prereq. for #105403) #117023

Misc. illumous build fixes (prereq. for #105403) #117023

gwr commented Jun 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

gwr commented Jun 25, 2025

Uh oh!

Uh oh!

am11 commented Jun 25, 2025

Uh oh!

jkotas Jun 25, 2025

Uh oh!

This comment was marked as spam.

Uh oh!

dotnet-policy-service bot commented Jun 26, 2025

Uh oh!

gwr commented Jul 2, 2025

Uh oh!

Uh oh!

Misc. illumous build fixes (prereq. for #105403) #117023

Are you sure you want to change the base?

Misc. illumous build fixes (prereq. for #105403) #117023

Conversation

gwr commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

gwr commented Jun 25, 2025

Uh oh!

Uh oh!

am11 commented Jun 25, 2025

Uh oh!

jkotas Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

dotnet-policy-service bot commented Jun 26, 2025

Uh oh!

gwr commented Jul 2, 2025

Uh oh!

Uh oh!

gwr commented Jun 25, 2025 •

edited

Loading