Skip to content

Update Linux/arm, Linux/arm64 cross containers to ones including pip3 #75167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BruceForstall
Copy link
Contributor

@ghost
Copy link

ghost commented Sep 6, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@BruceForstall
Copy link
Contributor Author

Enables #74961 to upload collections for Linux/arm, Linux/arm64.

@BruceForstall
Copy link
Contributor Author

@kunalspathak @dotnet/jit-contrib PTAL

@BruceForstall
Copy link
Contributor Author

Discussion about the failures here is over in dotnet/dotnet-buildtools-prereqs-docker#681

Namely, the docker images named in this PR aren't quite right.

Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest tags are always published at https://github.com/dotnet/versions/blob/main/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json, you can search for 18.04/cross/arm/ and arm64/ to find the tags.

(we also have Ubuntu 22.04 cross images with llvm 15 final toolchain released today)

@BruceForstall
Copy link
Contributor Author

Thanks, @am11. However, it appears the official build which publishes these Docker images did not succeed the last build (it appears it was manually canceled), and that last build is the one with my changes.

@BruceForstall BruceForstall force-pushed the UpdateLinuxArmCrossDockerContainers branch from 6ed1cca to 2053ec0 Compare September 7, 2022 18:59
BruceForstall added a commit to BruceForstall/runtime that referenced this pull request Sep 7, 2022
@BruceForstall
Copy link
Contributor Author

Unrelated:

Downloading 'https://dotnet.microsoft.com/download/dotnet/scripts/v1/dotnet-install.sh'
curl: (92) HTTP/2 stream 0 was not closed cleanly: CANCEL (err 8)
Curl failed; dumping some information about dotnet.microsoft.com for later investigation

@BruceForstall
Copy link
Contributor Author

"Libraries Test Run release mono Linux arm64 Debug" failure is #74795

@BruceForstall
Copy link
Contributor Author

@dotnet/jit-contrib Can I get a review on this?

Once this is merged, it should allow the new SuperPMI coreclr tests "run" collection to succeed on Linux/arm and Linux/arm64.

@BruceForstall
Copy link
Contributor Author

Anyone?

@kunalspathak
Copy link
Member

Curious, where do you get the version 20220907130538-70ed2e8 from?

@BruceForstall
Copy link
Contributor Author

Curious, where do you get the version 20220907130538-70ed2e8 from?

After a change to https://github.com/dotnet/dotnet-buildtools-prereqs-docker is merged, an internal build happens that updates https://github.com/dotnet/versions/blob/main/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json with the new container IDs.

@BruceForstall BruceForstall merged commit 5a2d0db into dotnet:main Sep 8, 2022
@BruceForstall BruceForstall deleted the UpdateLinuxArmCrossDockerContainers branch September 8, 2022 16:42
BruceForstall added a commit that referenced this pull request Sep 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants