-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[Release/7.0][PERF]Fix Mono Dotnet Generation #78413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release/7.0][PERF]Fix Mono Dotnet Generation #78413
Conversation
…to manually change the folder version ending.
Tagging subscribers to this area: @directhex Issue DetailsThis fixes the mono-dotnet generation for micro_mono performance runs on the release/7.0 branch as part of this: dotnet/performance#2719 A test run with this issue fixed is available here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2045552&view=results
|
@carlossanlop or @hoyosjs Can I get this merged if the tests come back clean? Thanks! |
We don't have more runway to merge this for the December release. The branch is currently closed for more changes, we will merge it when we reopen it for January release fixes. |
@LoopedBard3 Could you please explain what exactly this is fixing? |
For mono runs, we run some extra commands to generate and combine extra necessary files for the run. This is done in perf-job.yml and the files are then used in the Microbenchmarks.proj file. Currently, the product version being used in the paths is out of date and needs to be updated, which is the goal of this PR. |
Converted to draft to test some longer-term solutions while waiting for the ability to merge this in. |
This reverts commit a6e3ddd867f574a2db8b5e03014f4f37b9ddc47d.
463ac5f
to
cba2fdc
Compare
@LoopedBard3 how is this doing? I see it's still a draft. For the January release, once the servicing branches open for merging PRs, we will only have one day to get them merged, so I want to make sure this is ready that day. The branches open on Nov. 29th and close on Nov. 30th. |
@carlossanlop Thanks for the heads up! At the very least, this way of fixing the problem works, but there is a different one I am testing today/tomorrow in a different branch. If the other format works, I will update this PR with that code, otherwise I will mark as ready for review and get it reviewed. |
b976d81
to
cba2fdc
Compare
Running the final test: https://dev.azure.com/dnceng/internal/_build/results?buildId=2054827&view=results. |
@carlossanlop this is good to merge tomorrow with https://dev.azure.com/dnceng/internal/_build/results?buildId=2054924&view=results showing that this fix allows the broken runs to run. Thanks! |
@carlossanlop or @hoyosjs Can I get this merged? Don't want to miss the window. |
Not ready yet. We're waiting for branding. I'll take care of it when that happens, no worries. |
Branding has been completed. Approved for 7.0.2. CI failures unrelated. Infra change only. Signed-off by area owners. |
This fixes the mono-dotnet generation for micro_mono performance runs on the release/7.0 branch as part of this: dotnet/performance#2719
A test run with this issue fixed is available here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2045552&view=results