Skip to content

[Release/7.0][PERF]Fix Mono Dotnet Generation #78413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LoopedBard3
Copy link
Member

This fixes the mono-dotnet generation for micro_mono performance runs on the release/7.0 branch as part of this: dotnet/performance#2719

A test run with this issue fixed is available here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2045552&view=results

…to manually change the folder version ending.
@ghost
Copy link

ghost commented Nov 15, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This fixes the mono-dotnet generation for micro_mono performance runs on the release/7.0 branch as part of this: dotnet/performance#2719

A test run with this issue fixed is available here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2045552&view=results

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-mono

Milestone: -

@LoopedBard3
Copy link
Member Author

@carlossanlop or @hoyosjs Can I get this merged if the tests come back clean? Thanks!
@hoyosjs do you happen to know if there is a good way to get the product version from the eng/Version.prop to be usable within the yaml? Adding this to main and should help keep this from being a recurring change needed down the line.

@carlossanlop
Copy link
Contributor

We don't have more runway to merge this for the December release. The branch is currently closed for more changes, we will merge it when we reopen it for January release fixes.

@LoopedBard3 LoopedBard3 requested a review from radical as a code owner November 17, 2022 23:47
@radical
Copy link
Member

radical commented Nov 17, 2022

@LoopedBard3 Could you please explain what exactly this is fixing?

@LoopedBard3
Copy link
Member Author

For mono runs, we run some extra commands to generate and combine extra necessary files for the run. This is done in perf-job.yml and the files are then used in the Microbenchmarks.proj file. Currently, the product version being used in the paths is out of date and needs to be updated, which is the goal of this PR.

@LoopedBard3 LoopedBard3 marked this pull request as draft November 18, 2022 17:09
@LoopedBard3
Copy link
Member Author

Converted to draft to test some longer-term solutions while waiting for the ability to merge this in.

@LoopedBard3 LoopedBard3 force-pushed the PERFRelease7.0FixMonoDotnet branch from 463ac5f to cba2fdc Compare November 18, 2022 23:47
@carlossanlop
Copy link
Contributor

@LoopedBard3 how is this doing? I see it's still a draft. For the January release, once the servicing branches open for merging PRs, we will only have one day to get them merged, so I want to make sure this is ready that day.

The branches open on Nov. 29th and close on Nov. 30th.

@LoopedBard3
Copy link
Member Author

@carlossanlop Thanks for the heads up! At the very least, this way of fixing the problem works, but there is a different one I am testing today/tomorrow in a different branch. If the other format works, I will update this PR with that code, otherwise I will mark as ready for review and get it reviewed.

@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Nov 28, 2022

Running the final test: https://dev.azure.com/dnceng/internal/_build/results?buildId=2054827&view=results. The newly tested way did not work so keeping the method using sed. Found the minor error causing the other method not to work, readded it and running a test for it here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2054924&view=results. If there are still issues, can revert back to old method.

@LoopedBard3
Copy link
Member Author

@carlossanlop this is good to merge tomorrow with https://dev.azure.com/dnceng/internal/_build/results?buildId=2054924&view=results showing that this fix allows the broken runs to run. Thanks!

@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Nov 29, 2022

@carlossanlop or @hoyosjs Can I get this merged? Don't want to miss the window.

@carlossanlop
Copy link
Contributor

Not ready yet. We're waiting for branding. I'll take care of it when that happens, no worries.

@SamMonoRT SamMonoRT added this to the 7.0.2 milestone Nov 29, 2022
@LoopedBard3 LoopedBard3 linked an issue Nov 29, 2022 that may be closed by this pull request
3 tasks
@carlossanlop
Copy link
Contributor

Branding has been completed. Approved for 7.0.2. CI failures unrelated. Infra change only. Signed-off by area owners.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 7e6e7ce into dotnet:release/7.0 Nov 29, 2022
@LoopedBard3 LoopedBard3 deleted the PERFRelease7.0FixMonoDotnet branch November 29, 2022 23:36
@ghost ghost locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve mono-dotnet creation versioning Mono dotnet creation failing, failing micro_mono runs
6 participants