[release/7.0] [wasm] fix marshaling Error to C# as JSType.Any #79352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
lewing and
pavelsavara
as code owners
ghost
added
the
kg
approved these changes
Dec 7, 2022
marek-safar
added
Servicing-approved
|
Approved by Tactics (7.0.3). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #79340 to release/7.0
/cc @pavelsavara
Customer Impact
_marshal_cs_object_to_csis dynamic marshaling by type of JavaScript object. It used incomplete implementation ofErrormarshaling. This fix is using common method for marshaling Error, instead of the broken duplicate.Testing
Manual testing and new unit test.
Risk
The API is new in Net7 and the use case is edge case.