-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add test-tools feed to NuGet.config #47095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@Youssef1313 this means users of the nightly sdk will also need this feed when using mstest, is that a concern? |
I think either that, or maybe we can publish CodeCoverage to |
My vote would be for dotnet-tools. For now, we can use test-tools to unblock the codeflow PRs because SDK has a significant number of open PRs we need to get through. |
Code coverage should now push to dotnet-tools as well, re-running the original PR. |
or you know what, merge this, so the other PR is unblocked, and then we can solve the usage of dotnet-tools in other PR, I don't want to step on your toes by reverting a commit when I am not 100% sure it will work :) |
I think if the package is now on dotnet-tools that makes this PR obsolete since we can actually just retrigger the tests on the blocked PRs (since they would now be able to restore the package) |
See #47049 (comment)