Allow container targets to be loaded in more scenarios, even if the targets will be skipped #47693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvocations since we handle that now
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
baronfel
added
the
Area-Containers
surayya-MS
approved these changes
Mar 18, 2025
|
Per offline conversation, can / should we include integration tests for this scenario? |
yes, will be doing this today |
|
Ok, test added! |
baronfel
changed the title
surayya-MS
reviewed
Mar 19, 2025
src/Tests/Microsoft.NET.Build.Containers.IntegrationTests/EndToEndTests.cs
Outdated
Show resolved
Hide resolved
|
LGTM |
baronfel
force-pushed
the
do-not-break-classlibs-when-multi-tfm-publishing-containers
branch
from
ae63da7 to
5c03933
Compare
baronfel
deleted the
do-not-break-classlibs-when-multi-tfm-publishing-containers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When publishing a solution with
dotnet publish /t:PublishContainerwhen the solution contains at least one multi-targeted project, container publish fails because thePublishContainertarget isn't loaded when targeting multiple TFMs.This is an artifact of our original single-TFM nature that isn't apparent when publishing single projects and really only shows up when publishing at the solution level. We need to enable this target to be called in a multi-TFM context even if the target itself doesn't support multi-TFM publishing. This is safe because the SDK itself blocks multi-TFM publishing of a project (you get NETSDK1129 errors), we just need to not block libraries and other non-exe-projects from being able to be built at the solution level.
Impact
Almost completely blocking for any solution-level container publish - the only workaround is making a stub
PublishContainerTarget in the library projects, which is very gnarly and likely will shoot us in the foot later on.Risk
Medium - this fixes library-style projects from breaking in this scenario, but without the NETSDK1129 error you'd end up in a weird state. We probably need to go back and add multi-TFM detection and processing inside the PublishContainer target itself to be safest, but that's an even larger change.
Testing