Allow @ as separator in #:package

[jjonescz]

Resolves #47990.

[Copilot]

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs:820

• [nitpick] Consider renaming the local variable 'i' to a more descriptive name (e.g., 'separatorIndex') to enhance code clarity.

var i = separators != null ? directiveText.AsSpan().IndexOfAny(separators) : directiveText.IndexOf(' ', StringComparison.Ordinal);

[RikkiGibson]

So are we planning to be tolerant of different separators here for the short term? Or maybe indefinitely? And are there other changes coming for the allowed/permitted separators for #:sdk and #:property?

[jjonescz]

So are we planning to be tolerant of different separators here for the short term? Or maybe indefinitely? And are there other changes coming for the allowed/permitted separators for #:sdk and #:property?

Good questions.

If we are doing @ for packages, maybe we want also / for sdk to be consistent with <Project Sdk="Name/Version"> syntax.

We could also have a "breaking change" and say spaces are not allowed for packages (and sdk if we change that as well). I would actually prefer that as there would be just one common way to specify the same directives. (The downside might be you cannot choose one separator - space - for everything like you can today.) But curious what others think.

[RikkiGibson]

I would prefer that only one separator is permitted for each directive kind. But, I also think being tolerant during the experimental phase is fine, to allow people to "offboard" from spaces as delimiters.