Skip to content

Remove usage of Alpine 3.18 Helix image and upgrade to Alpine 3.22 #49238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 6, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 3, 2025

Alpine 3.18 is End of Life (EOL) and the associated Helix image mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.18-helix-amd64 is no longer maintained. This change updates the Helix target container configuration to use Alpine 3.22, which is the current supported version.

Changes made:

  • Updated helixTargetContainer in eng/pipelines/templates/jobs/sdk-job-matrix.yml from alpine-3.18-helix-amd64 to alpine-3.22-helix-amd64

This is a minimal change that ensures the Alpine container-based builds use a supported and maintained Helix image while maintaining the same functionality.

Fixes #49229.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] Remove usage of Alpine 3.18 Helix image Remove usage of Alpine 3.18 Helix image and upgrade to Alpine 3.22 Jun 3, 2025
@Copilot Copilot AI requested a review from nagilson June 3, 2025 20:57
Copilot finished work on behalf of nagilson June 3, 2025 20:57
@nagilson nagilson marked this pull request as ready for review June 3, 2025 21:02
@nagilson nagilson requested a review from a team June 3, 2025 21:02
@nagilson nagilson enabled auto-merge June 3, 2025 21:02
helixTargetContainer: $(helixTargetContainerPrefix)alpine-3.18-helix-amd64
helixTargetContainer: $(helixTargetContainerPrefix)alpine-3.22-helix-amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiYanni @nagilson Since runTests is currently set to false, changes to other parameters will not take effect. Would you like to enable testing so that these changes can be applied?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot May you please enable runTests and set it to true for this Helix image based on the above comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled runTests and set it to true for the Alpine Helix image. The change ensures that the Alpine 3.22 Helix image configuration will take effect with testing enabled. See commit 6e63441.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot The container tag still says alpine319, may you fix that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'm actually not sure if we want to runTests for this leg or not... I will defer that decision to @MiYanni, but I don't see why that'd change.. so maybe we don't want that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the container tag. Updated from alpine319WithNode to alpine322WithNode across all pipeline files to match the Alpine 3.22 upgrade. See commit 435dda0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right - I've reverted runTests back to false for the Alpine configuration to match the original behavior. The change now only upgrades from Alpine 3.18 to 3.22 without enabling testing. See commit c599a92.

auto-merge was automatically disabled June 4, 2025 17:28

Head branch was pushed to by a user without write access

Copilot finished work on behalf of nagilson June 4, 2025 17:28
Copilot finished work on behalf of nagilson June 4, 2025 20:44
Copy link
Contributor Author

Copilot AI commented Jun 4, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Copilot finished work on behalf of nagilson June 4, 2025 20:48
Copy link
Member

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine to not update the testability for the time being. I know you've been investigating them, @v-wuzhai. But updating the image here should be done independent of the tests running. If we want to see if the tests work (or how to fix them), that can be done in a separate PR.

@MiYanni MiYanni added the Blocked Issue is blocked on an external dependency label Jun 5, 2025
@MiYanni
Copy link
Member

MiYanni commented Jun 5, 2025

I've set this PR as Blocked until dotnet/core#9865 is resolved. Looks like the container isn't available yet:

Error response from daemon: manifest for mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.22-WithNode not found: manifest unknown: manifest tagged by "alpine-3.22-WithNode" is not found

@richlander
Copy link
Member

This is the image you want. We removed "withNode".

https://github.com/dotnet/runtime/blob/7e0d87189399c53045fca55740dafe86ea2cb605/eng/pipelines/common/templates/pipeline-with-resources.yml#L70

@MiYanni
Copy link
Member

MiYanni commented Jun 5, 2025

@copilot Please update the image name from alpine-3.22-WithNode to alpine-3.22. Also update the container name from alpine322WithNode to alpine322.

Copy link
Contributor Author

Copilot AI commented Jun 5, 2025

@copilot Please update the image name from alpine-3.22-WithNode to alpine-3.22. Also update the container name from alpine322WithNode to alpine322.

Updated both the image name from alpine-3.22-WithNode to alpine-3.22 and the container name from alpine322WithNode to alpine322 across all pipeline files. See commit 3ed98ec.

Copilot finished work on behalf of MiYanni June 5, 2025 20:59
@MiYanni
Copy link
Member

MiYanni commented Jun 5, 2025

@copilot Please update the image name from alpine-3.22-WithNode to alpine-3.22. Also update the container name from alpine322WithNode to alpine322.

Updated both the image name from alpine-3.22-WithNode to alpine-3.22 and the container name from alpine322WithNode to alpine322 across all pipeline files. See commit 3ed98ec.

@copilot I made a mistake. The image name should be changed from alpine-3.22 to alpine-3.22-amd64. And the container name should be changed from alpine322 to alpine322Amd64.

Copy link
Contributor Author

Copilot AI commented Jun 5, 2025

@copilot Please update the image name from alpine-3.22-WithNode to alpine-3.22. Also update the container name from alpine322WithNode to alpine322.

Updated both the image name from ...

Updated both the image name from alpine-3.22 to alpine-3.22-amd64 and the container name from alpine322 to alpine322Amd64 across all pipeline files. See commit 9ad57fe.

Copilot finished work on behalf of MiYanni June 5, 2025 21:22
@MiYanni
Copy link
Member

MiYanni commented Jun 6, 2025

@copilot The helixTargetContainer should be alpine-3.22-helix-amd64.

Copy link
Contributor Author

Copilot AI commented Jun 6, 2025

@copilot The helixTargetContainer should be alpine-3.22-helix-amd64.

Updated the helixTargetContainer from alpine-3.22-amd64 to alpine-3.22-helix-amd64 to use the correct Helix image. See commit 6368f70.

Copilot finished work on behalf of MiYanni June 6, 2025 00:23
@MiYanni MiYanni removed the Blocked Issue is blocked on an external dependency label Jun 6, 2025
@MiYanni MiYanni enabled auto-merge June 6, 2025 01:02
@MiYanni MiYanni merged commit 0e331d9 into main Jun 6, 2025
29 checks passed
@MiYanni MiYanni deleted the copilot/fix-49229 branch June 6, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of Alpine 3.18 Helix image
5 participants