-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove usage of Alpine 3.18 Helix image and upgrade to Alpine 3.22 #49238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: nagilson <[email protected]>
helixTargetContainer: $(helixTargetContainerPrefix)alpine-3.18-helix-amd64 | ||
helixTargetContainer: $(helixTargetContainerPrefix)alpine-3.22-helix-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fairly certain these images need to be provisioned. Ah, it looks like it exists already: https://github.com/dotnet/versions/blob/417ebc99139e5f3d8095b0c02bc660fa831d336d/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json#L510
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot May you please enable runTests and set it to true for this Helix image based on the above comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've enabled runTests and set it to true for the Alpine Helix image. The change ensures that the Alpine 3.22 Helix image configuration will take effect with testing enabled. See commit 6e63441.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot The container tag still says alpine319, may you fix that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I'm actually not sure if we want to runTests for this leg or not... I will defer that decision to @MiYanni, but I don't see why that'd change.. so maybe we don't want that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the container tag. Updated from alpine319WithNode
to alpine322WithNode
across all pipeline files to match the Alpine 3.22 upgrade. See commit 435dda0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right - I've reverted runTests back to false for the Alpine configuration to match the original behavior. The change now only upgrades from Alpine 3.18 to 3.22 without enabling testing. See commit c599a92.
Co-authored-by: nagilson <[email protected]>
Head branch was pushed to by a user without write access
… upgrade Co-authored-by: nagilson <[email protected]>
Co-authored-by: nagilson <[email protected]>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine to not update the testability for the time being. I know you've been investigating them, @v-wuzhai. But updating the image here should be done independent of the tests running. If we want to see if the tests work (or how to fix them), that can be done in a separate PR.
I've set this PR as
|
This is the image you want. We removed "withNode". |
@copilot Please update the image name from |
Co-authored-by: MiYanni <[email protected]>
Updated both the image name from |
@copilot I made a mistake. The image name should be changed from |
…22-amd64 Co-authored-by: MiYanni <[email protected]>
Updated both the image name from |
@copilot The |
Co-authored-by: MiYanni <[email protected]>
Alpine 3.18 is End of Life (EOL) and the associated Helix image
mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.18-helix-amd64
is no longer maintained. This change updates the Helix target container configuration to use Alpine 3.22, which is the current supported version.Changes made:
helixTargetContainer
ineng/pipelines/templates/jobs/sdk-job-matrix.yml
fromalpine-3.18-helix-amd64
toalpine-3.22-helix-amd64
This is a minimal change that ensures the Alpine container-based builds use a supported and maintained Helix image while maintaining the same functionality.
Fixes #49229.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.