Skip to content

[main] Update dependencies from nuget/nuget.client #49242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 13, 2025
Merged

[main] Update dependencies from nuget/nuget.client #49242

merged 6 commits into from
Jun 13, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 4, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/nuget/nuget.client

@dotnet-maestro
Update dependencies from https://github.com/nuget/nuget.client build …
28c6ea9 
…6.15.0.77

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 6.15.0-preview.1.70 -> To Version 6.15.0-preview.1.77
dotnet-maestro bot and others added 2 commits June 6, 2025 12:26
@dotnet-maestro
Update dependencies from https://github.com/nuget/nuget.client build …
2bdd090 
…6.15.0.78

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 6.15.0-preview.1.70 -> To Version 6.15.0-preview.1.78
@MiYanni
Merge branch 'main' into darc-main-dfdd07c8-a19b-4a2f-97c3-11cae5af91fc
8040f40
This was referenced Jun 11, 2025
Open
Open
Open
Open
Open
Open
@build-analysis build-analysis bot mentioned this pull request Jun 12, 2025
Open
@MiYanni
Copy link
Member

MiYanni commented Jun 12, 2025

@nkolev92 Seems like this new nuget.client version introduces test failures for some of the GivenThatWeWantToBuildADesktopExeWithNetStandardLib tests. Can you take a look?

@nkolev92
Copy link
Contributor

The tests are failing with NU1015.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=1065925&view=ms.vss-test-web.build-test-results-tab&runId=28819926&resultId=104213&paneView=debug

Basically the PackageReference is missing a version.

This was an intentional breaking change, NuGet/NuGet.Client@3a9fe1b.

cc @zivkan

Can we update the tests to include a version?

@nkolev92
Copy link
Contributor

cc @Nigusu-Allehu who is our hotseat

@zivkan
Copy link
Member

zivkan commented Jun 13, 2025

I had a look at two or three of the tests that were using test assets with a PackageRef without a version. Those tests had no reason to use a PackageRef without a version, so I modified the test asset to include a version. I don't know if there are other tests using the same test asset where no version makes sense, but all the tests are passing now.

@MiYanni MiYanni merged commit f058035 into main Jun 13, 2025
33 of 34 checks passed
@MiYanni MiYanni deleted the darc-main-dfdd07c8-a19b-4a2f-97c3-11cae5af91fc branch June 13, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiYanni MiYanni MiYanni approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MiYanni @nkolev92 @zivkan @v-wuzhai