Added the exists method to the FileSystem. #909
Conversation
|
|
|
@AFFogarty Sorry it took me some time to get this PR out. Please take a look and let me know. |
There was a problem hiding this comment.
Thank you for your PR, @sunildixit. I have left a few comments. 😃
| using var tempDirectory = new TemporaryDirectory(); | ||
| string path = Path.Combine(tempDirectory.Path, "temp-table"); | ||
|
|
||
| _spark |
There was a problem hiding this comment.
Does this fit on one line?
There was a problem hiding this comment.
I have added it to one line.
|
|
||
| Assert.NotNull(dataFile); | ||
|
|
||
| Assert.True(fs.Exists(dataFile)); |
There was a problem hiding this comment.
Maybe we should add an assertion to test that fs.Exists() returns false on a non-existent path?
For example you could do something like this:
string path = Path.Combine(tempDirectory.Path, "temp-table");
Assert.False(fs.Exists(path));
_spark.Range(25).Write().Csv(path);
Assert.True(fs.Exists(path));
That way, you prove that the Exists() return value changes after writing to that path.
There was a problem hiding this comment.
Great catch. I have added the assertion.
| @@ -55,6 +55,14 @@ public bool Delete(string path, bool recursive = true) | |||
| return (bool)_jvmObject.Invoke("delete", pathObject, recursive); | |||
| } | |||
|
|
|||
| public bool Exists(string path) | |||
There was a problem hiding this comment.
Could you please add a documentation comment describing the method? You can copy its content from open-source org.apache.hadoop.fs.FileSystem.
| @@ -52,5 +53,28 @@ public void TestDelete() | |||
|
|
|||
| Assert.False(Directory.Exists(path)); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void TestExists() | |||
There was a problem hiding this comment.
Could you please add a documentation comment describing the test?
There was a problem hiding this comment.
Added the documentation about the test
imback82
dismissed stale reviews from suhsteve, Niharikadutta, and AFFogarty
via
84b3a43
This PR adds the exists(string filePath) api to the FileSystem, which will allow the users to check whether a given folder or file exists in the file system or not.
I'll be adding more methods once I know, that I have done this work correctly.
Example: Check for an existing file
This PR relates to #328