Skip to content

Use reflection to set host header when forwarding #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2022
Merged

Use reflection to set host header when forwarding #171

merged 6 commits into from
Aug 26, 2022

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Aug 25, 2022

Fixes #156

Verified in debugger that the reflection codepath is not hit on normal requests to framework app, but is hit and updates the url correctly in the coreapp:

image

@twsouthwick
Copy link
Member

fyi - you're previous build failed in part due to using outdated vms. I have a PR #172 to fix that.

@HaoK HaoK enabled auto-merge (squash) August 26, 2022 01:46
@HaoK HaoK merged commit 6fd3385 into main Aug 26, 2022
@HaoK HaoK deleted the haok/ref branch August 26, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host header is changed too late when using UseHostHeaderForRequestUrl
4 participants