Use HttpValueCollection as base class for custom collections #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables .ToString() to function as similarly to .NET Framework as possible. That's the only observable difference by adding this as the base class.
twsouthwick
commented
Nov 11, 2022
| @@ -87,7 +87,7 @@ internal void FillFromString(string s, bool urlencoded = false, Encoding? encodi | |||
| } | |||
| } | |||
|
|
|||
| public override string ToString() => ToString(false); | |||
| public override string ToString() => ToString(true); | |||
There was a problem hiding this comment.
not sure why this was false - on framework, this is true, so changing it back
twsouthwick
commented
Nov 11, 2022
| @@ -100,17 +100,17 @@ private string ToString(bool urlencoded) | |||
|
|
|||
| var s = new StringBuilder(); | |||
|
|
|||
| for (var i = 0; i < count; i++) | |||
| foreach (string k in this) | |||
There was a problem hiding this comment.
this change is because we can't access by int, but rather by string
Tratcher
approved these changes
Nov 11, 2022
|
@Tratcher the build is failing with "Failed to request agent. Exception Image Build.Server.Amd64.VS2017.Open doesn't exist in pool NetCore-Public". Any ideas? |
|
No, that's a question for the first-responders channel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables .ToString() to function as similarly to .NET Framework as
possible. That's the only observable difference by adding this as the
base class.